##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r397:4367a81c default
r887:175782be default
Show More
test_admin_repo_settings.py
118 lines | 4.4 KiB | text/x-python | PythonLexer
/ rhodecode / tests / functional / test_admin_repo_settings.py
project: added all source files and assets
r1 # -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369 import mock
project: added all source files and assets
r1 import pytest
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 import rhodecode
from rhodecode.model.settings import SettingsModel
project: added all source files and assets
r1 from rhodecode.tests import url, HG_REPO
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369 from rhodecode.tests.utils import AssertResponse
project: added all source files and assets
r1
@pytest.mark.usefixtures('autologin_user', 'app')
class TestAdminRepoSettingsController:
@pytest.mark.parametrize('urlname', [
'edit_repo',
'edit_repo_perms',
'edit_repo_advanced',
'repo_vcs_settings',
'edit_repo_fields',
'repo_settings_issuetracker',
'edit_repo_caches',
'edit_repo_remote',
'edit_repo_statistics',
])
def test_simple_get(self, urlname, app):
app.get(url(urlname, repo_name=HG_REPO))
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 @pytest.mark.parametrize('setting_name, setting_backends', [
('hg_use_rebase_for_merging', ['hg']),
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369 ])
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 def test_labs_settings_visible_if_enabled(
self, setting_name, setting_backends, backend):
if backend.alias not in setting_backends:
pytest.skip('Setting not available for backend {}'.format(backend))
vcs_settings_url = url(
'repo_vcs_settings', repo_name=backend.repo.repo_name)
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369
with mock.patch.dict(
rhodecode.CONFIG, {'labs_settings_active': 'true'}):
response = self.app.get(vcs_settings_url)
assertr = AssertResponse(response)
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 assertr.one_element_exists('#rhodecode_{}'.format(setting_name))
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 @pytest.mark.parametrize('setting_name, setting_backends', [
('hg_use_rebase_for_merging', ['hg']),
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369 ])
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 def test_labs_settings_not_visible_if_disabled(
self, setting_name, setting_backends, backend):
if backend.alias not in setting_backends:
pytest.skip('Setting not available for backend {}'.format(backend))
vcs_settings_url = url(
'repo_vcs_settings', repo_name=backend.repo.repo_name)
Martin Bornhold
tests: Add test to check that the rebase-merge setting is available on hg repos.
r369
with mock.patch.dict(
rhodecode.CONFIG, {'labs_settings_active': 'false'}):
response = self.app.get(vcs_settings_url)
assertr = AssertResponse(response)
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 assertr.no_element_exists('#rhodecode_{}'.format(setting_name))
@pytest.mark.parametrize('setting_name, setting_backends', [
('hg_use_rebase_for_merging', ['hg']),
])
def test_update_boolean_settings(
self, csrf_token, setting_name, setting_backends, backend):
if backend.alias not in setting_backends:
pytest.skip('Setting not available for backend {}'.format(backend))
Martin Bornhold
tests: Fix test that modifies test repo settings....
r397 repo = backend.create_repo()
settings_model = SettingsModel(repo=repo)
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 vcs_settings_url = url(
Martin Bornhold
tests: Fix test that modifies test repo settings....
r397 'repo_vcs_settings', repo_name=repo.repo_name)
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370
self.app.post(
vcs_settings_url,
params={
Martin Bornhold
tests: Fix test that modifies test repo settings....
r397 'inherit_global_settings': False,
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 'new_svn_branch': 'dummy-value-for-testing',
'new_svn_tag': 'dummy-value-for-testing',
'rhodecode_{}'.format(setting_name): 'true',
'csrf_token': csrf_token,
})
setting = settings_model.get_setting_by_name(setting_name)
assert setting.app_settings_value
self.app.post(
vcs_settings_url,
params={
Martin Bornhold
tests: Fix test that modifies test repo settings....
r397 'inherit_global_settings': False,
Martin Bornhold
tests: Test the hg rebase setting on repo vcs setings page.
r370 'new_svn_branch': 'dummy-value-for-testing',
'new_svn_tag': 'dummy-value-for-testing',
'rhodecode_{}'.format(setting_name): 'false',
'csrf_token': csrf_token,
})
setting = settings_model.get_setting_by_name(setting_name)
assert not setting.app_settings_value