##// END OF EJS Templates
todos: all todos needs to be resolved for merge to happen....
todos: all todos needs to be resolved for merge to happen. This will prevent the outdated todos beeing automatically marked as solved becuase of bigger diff changes. It's better to mark commits quickly as resolved instead of potentially have unresolved todos hidden because of invlidation logic.

File last commit:

r1323:41333240 default
r1342:44fc3039 default
Show More
test_pullrequest.py
93 lines | 3.3 KiB | text/x-python | PythonLexer
dan
events: add pull request events
r378 # -*- coding: utf-8 -*-
license: updated copyright year to 2017
r1271 # Copyright (C) 2010-2017 RhodeCode GmbH
dan
events: add pull request events
r378 #
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import pytest
from rhodecode.tests.events.conftest import EventCatcher
comments: renamed ChangesetCommentsModel to CommentsModel to reflect what it actually does....
r1323 from rhodecode.model.comment import CommentsModel
dan
events: add pull request events
r378 from rhodecode.model.pull_request import PullRequestModel
from rhodecode.events import (
PullRequestCreateEvent,
PullRequestUpdateEvent,
dan
events: add an event for pull request comments with review status
r443 PullRequestCommentEvent,
dan
events: add pull request events
r378 PullRequestReviewEvent,
PullRequestMergeEvent,
PullRequestCloseEvent,
)
dan
events: fix bugs with serialization of repo/pr events and add tests for those cases
r389 # TODO: dan: make the serialization tests complete json comparisons
@pytest.mark.backends("git", "hg")
@pytest.mark.parametrize('EventClass', [
PullRequestCreateEvent,
PullRequestUpdateEvent,
PullRequestReviewEvent,
PullRequestMergeEvent,
PullRequestCloseEvent,
])
def test_pullrequest_events_serialized(pr_util, EventClass):
pr = pr_util.create_pull_request()
event = EventClass(pr)
data = event.as_dict()
assert data['name'] == EventClass.name
assert data['repo']['repo_name'] == pr.target_repo.repo_name
assert data['pullrequest']['pull_request_id'] == pr.pull_request_id
dan
events: fix bug, 'url' was not in dict
r392 assert data['pullrequest']['url']
dan
events: add pull request events
r378
@pytest.mark.backends("git", "hg")
def test_create_pull_request_events(pr_util):
with EventCatcher() as event_catcher:
pr_util.create_pull_request()
assert PullRequestCreateEvent in event_catcher.events_types
dan
events: add an event for pull request comments with review status
r443 @pytest.mark.backends("git", "hg")
def test_pullrequest_comment_events_serialized(pr_util):
pr = pr_util.create_pull_request()
comments: renamed ChangesetCommentsModel to CommentsModel to reflect what it actually does....
r1323 comment = CommentsModel().get_comments(
dan
events: add an event for pull request comments with review status
r443 pr.target_repo.repo_id, pull_request=pr)[0]
event = PullRequestCommentEvent(pr, comment)
data = event.as_dict()
assert data['name'] == PullRequestCommentEvent.name
assert data['repo']['repo_name'] == pr.target_repo.repo_name
assert data['pullrequest']['pull_request_id'] == pr.pull_request_id
assert data['pullrequest']['url']
assert data['comment']['text'] == comment.text
dan
events: add pull request events
r378
@pytest.mark.backends("git", "hg")
def test_close_pull_request_events(pr_util, user_admin):
pr = pr_util.create_pull_request()
with EventCatcher() as event_catcher:
PullRequestModel().close_pull_request(pr, user_admin)
assert PullRequestCloseEvent in event_catcher.events_types
@pytest.mark.backends("git", "hg")
def test_close_pull_request_with_comment_events(pr_util, user_admin):
pr = pr_util.create_pull_request()
with EventCatcher() as event_catcher:
PullRequestModel().close_pull_request_with_comment(
pr, user_admin, pr.target_repo)
assert PullRequestCloseEvent in event_catcher.events_types