u/pc/rhodecode-enterprise-ce-fork-pc Files · docs/code-review/review-diffs.rst

auth: don't break hashing in case of user with empty password....

auth: don't break hashing in case of user with empty password. In some cases such as LDAP user created via external scripts users might set the passwords to empty. The hashing uses the md5(password_hash) to store reference to detect password changes and forbid using the same password. In case of pure LDAP users this is not valid, and we shouldn't raise Errors in such case. This change makes it work for empty passwords now.

marcink - - Load All Authors

File last commit:

r1:854a839a default


                r2203:8a18c3c3

default

Download file

             review-diffs.rst
        
                    42 lines
            
             | 1.0 KiB
            
                | text/x-rst
            
             |
                RstLexer
            
             / docs / code-review / review-diffs.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
project: added all source files and assets

              r1
            
      .. _code-diff-side-ref:

      Reviewing Diffs

      ---------------

      Diffs are representations of changes made between different changesets of

      a file. |RCE| provides 4 different types of diffs for each commit or

      changeset, and depending on your preference you can use whichever for code

      review purposes.

      * Plain diff

      * Full diff

      * Side-by-side diff

      * Raw diff

      Reviewing Changes

      -----------------

      |RCM| displays all code changes made with each commit. Removed content is

      marked in red and new content in green.

      .. image:: ../images/plain-diff.png

         :alt: Plain Diff

      Side-By-Side Diffs

      ------------------

      To review code with a side-by-side diff, use the following steps:

      1. Open the repository in which you wish to review a file

      2. Select the revision you wish to review

      3. Select the side-by-side diff icon beside the file name

      .. image:: ../images/side-by-side-diff.png

         :alt: Side by side diff

      Notifying Users

      ---------------

      To notify other users of you comments, or requests for feedback,

      see :ref:`review-notifications-ref`

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink project: added all source files and assets	r1	.. _code-diff-side-ref:

		Reviewing Diffs
		---------------

		Diffs are representations of changes made between different changesets of
		a file. \|RCE\| provides 4 different types of diffs for each commit or
		changeset, and depending on your preference you can use whichever for code
		review purposes.

		* Plain diff
		* Full diff
		* Side-by-side diff
		* Raw diff

		Reviewing Changes
		-----------------

		\|RCM\| displays all code changes made with each commit. Removed content is
		marked in red and new content in green.

		.. image:: ../images/plain-diff.png
		:alt: Plain Diff

		Side-By-Side Diffs
		------------------

		To review code with a side-by-side diff, use the following steps:

		1. Open the repository in which you wish to review a file
		2. Select the revision you wish to review
		3. Select the side-by-side diff icon beside the file name

		.. image:: ../images/side-by-side-diff.png
		:alt: Side by side diff


		Notifying Users
		---------------

		To notify other users of you comments, or requests for feedback,
		see :ref:`review-notifications-ref`