# HG changeset patch
# User Martin Bornhold <martin@rhodecode.com>
# Date 2016-10-23 13:57:24
# Node ID 928bf19b3e785e3f578c46420cddc4bad94ae643
# Parent  f58888bca7f31af1b10f51205a0431bf829083d7

db: Refactor reference conversion to an reusable method.

diff --git a/rhodecode/model/db.py b/rhodecode/model/db.py
--- a/rhodecode/model/db.py
+++ b/rhodecode/model/db.py
@@ -3064,8 +3064,7 @@ class _PullRequestBase(BaseModel):
 
     @property
     def source_ref_parts(self):
-        refs = self.source_ref.split(':')
-        return Reference(refs[0], refs[1], refs[2])
+        return self.unicode_to_reference(self.source_ref)
 
     @declared_attr
     def target_repo(cls):
@@ -3075,8 +3074,28 @@ class _PullRequestBase(BaseModel):
 
     @property
     def target_ref_parts(self):
-        refs = self.target_ref.split(':')
-        return Reference(refs[0], refs[1], refs[2])
+        return self.unicode_to_reference(self.target_ref)
+
+    def unicode_to_reference(self, raw):
+        """
+        Convert a unicode (or string) to a reference object.
+        If unicode evaluates to False it returns None.
+        """
+        if raw:
+            refs = raw.split(':')
+            return Reference(*refs)
+        else:
+            return None
+
+    def reference_to_unicode(self, ref):
+        """
+        Convert a reference object to unicode.
+        If reference is None it returns None.
+        """
+        if ref:
+            return u':'.join(ref)
+        else:
+            return None
 
 
 class PullRequest(Base, _PullRequestBase):