# HG changeset patch # User Daniel Dourvaris # Date 2016-09-14 20:03:34 # Node ID bf02f99de25da7fb3715e0e844f3218bde736f13 # Parent 6ce205ffa391e81820a63b68d61608e939ca38a5 events: fix bug with _commits_as_dict which was returning only even commits diff --git a/rhodecode/events/repo.py b/rhodecode/events/repo.py --- a/rhodecode/events/repo.py +++ b/rhodecode/events/repo.py @@ -57,7 +57,8 @@ def _commits_as_dict(commit_ids, repos): vcs_repo = repo.scm_instance(cache=False) try: - for commit_id in needed_commits: + # use copy of needed_commits since we modify it while iterating + for commit_id in list(needed_commits): try: cs = vcs_repo.get_changeset(commit_id) except CommitDoesNotExistError: