# HG changeset patch # User Marcin Kuzminski # Date 2017-11-08 15:44:21 # Node ID c2059633ac788a52e9f21d702fd3fdab24458ee7 # Parent b8ef797e676cf235f5b7b996111fde8c69808b88 helpers: fix metatags extraction in case description is empty diff --git a/rhodecode/lib/helpers.py b/rhodecode/lib/helpers.py --- a/rhodecode/lib/helpers.py +++ b/rhodecode/lib/helpers.py @@ -986,10 +986,10 @@ def extract_metatags(value): """ Extract supported meta-tags from given text value """ + tags = [] if not value: - return '' + return tags, '' - tags = [] for key, val in tags_paterns.items(): pat, replace_html = val tags.extend([(key, x.group()) for x in pat.finditer(value)]) diff --git a/rhodecode/tests/lib/test_libs.py b/rhodecode/tests/lib/test_libs.py --- a/rhodecode/tests/lib/test_libs.py +++ b/rhodecode/tests/lib/test_libs.py @@ -187,6 +187,14 @@ def test_age_in_future(age_args, expecte @pytest.mark.parametrize("sample, expected_tags", [ + # entry + (( + "" + ), + [ + + ]), + # entry (( "hello world [stale]" ),