##// END OF EJS Templates
vcs: Minimal change to expose the shadow repository...
vcs: Minimal change to expose the shadow repository Based on my original research, this was the "minimal" starting point. It shows that three concepts are needed for the "repo_name": * From the security standpoint we think of the shadow repository having the same ACL as the target repository of the pull request. This is because the pull request itself is considered to be a part of the target repository. Out of this thought, the variable "acl_repo_name" is used whenever we want to check permissions or when we need the database configuration of the repository. An alternative name would have been "db_repo_name", but the usage for ACL checking is the most important one. * From the web interaction perspective, we need the URL which was originally used to get to the repository. This is because based on this base URL commands can be identified. Especially for Git this is important, so that the commands are correctly recognized. Since the URL is in the focus, this is called "url_repo_name". * Finally we have to deal with the repository on the file system. This is what the VCS layer deal with normally, so this name is called "vcs_repo_name". The original repository interaction is a special case where all three names are the same. When interacting with a pull request, these three names are typically all different. This change is minimal in a sense that it just makes the interaction with a shadow repository barely work, without checking any special constraints yet. This was the starting point for further work on this topic.

File last commit:

r1:854a839a default
r887:175782be default
Show More
test_repo_groups.py
79 lines | 2.7 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2016 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import mock
import pylons
import pytest
from pylons import tmpl_context as c
@pytest.fixture
def current_user(request, user_util):
user = user_util.create_user()
request_mock = mock.Mock(user=user)
pylons.request._push_object(request_mock)
@request.addfinalizer
def cleanup():
pylons.request._pop_object()
return user
@pytest.fixture
def personal_group_with_parent(user_util, current_user):
group_read_only = user_util.create_repo_group()
user_util.grant_user_permission_to_repo_group(
group_read_only, current_user, 'group.read')
# TODO: johbo: This should go into the business models
group_as_admin = user_util.create_repo_group(
owner=current_user)
group_as_admin.parent_group = group_read_only
group_as_admin.group_name = group_as_admin.get_new_name(
group_as_admin.group_name)
return group_as_admin
@pytest.fixture
def controller():
from rhodecode.controllers.admin import repo_groups
return repo_groups.RepoGroupsController()
def test_repo_groups_load_defaults(
current_user, personal_group_with_parent, controller):
personal_group = personal_group_with_parent
controller._RepoGroupsController__load_defaults(True, personal_group)
expected_list = ['-1', personal_group.parent_group.group_id]
returned_group_ids = [group[0] for group in c.repo_groups]
assert returned_group_ids == expected_list
def test_repo_groups_load_defaults_with_missing_group(
current_user, personal_group_with_parent, controller):
personal_group = personal_group_with_parent
controller._RepoGroupsController__load_defaults(True)
expected_list = sorted(['-1', personal_group.group_id])
returned_group_ids = sorted([group[0] for group in c.repo_groups])
assert returned_group_ids == expected_list