##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r1785:1cce4ff2 default
r2038:2bdf9d4d default
Show More
admin_log_base.mako
64 lines | 2.0 KiB | application/x-mako | MakoHtmlLexer
<%namespace name="base" file="/base/base.mako"/>
%if c.audit_logs:
<table class="rctable admin_log">
<tr>
<th>${_('Username')}</th>
<th>${_('Action')}</th>
<th>${_('Action Data')}</th>
<th>${_('Repository')}</th>
<th>${_('Date')}</th>
<th>${_('IP')}</th>
</tr>
%for cnt,l in enumerate(c.audit_logs):
<tr class="parity${cnt%2}">
<td class="td-user">
%if l.user is not None:
${base.gravatar_with_user(l.user.email)}
%else:
${l.username}
%endif
</td>
<td class="td-journalaction">
% if l.version == l.VERSION_1:
${h.action_parser(l)[0]()}
% else:
${h.literal(l.action)}
% endif
<div class="journal_action_params">
% if l.version == l.VERSION_1:
${h.literal(h.action_parser(l)[1]())}
% endif
</div>
</td>
<td>
% if l.version == l.VERSION_2:
<a href="#" onclick="$('#entry-'+${l.user_log_id}).toggle();return false">${_('toggle')}</a>
<div id="entry-${l.user_log_id}" style="display: none">
<pre>${h.json.dumps(l.action_data, indent=4, sort_keys=True)}</pre>
</div>
% else:
<pre title="${_('data not available for v1 entries type')}">-</pre>
% endif
</td>
<td class="td-componentname">
%if l.repository is not None:
${h.link_to(l.repository.repo_name, h.route_path('repo_summary',repo_name=l.repository.repo_name))}
%else:
${l.repository_name}
%endif
</td>
<td class="td-time">${h.format_date(l.action_date)}</td>
<td class="td-ip">${l.user_ip}</td>
</tr>
%endfor
</table>
<div class="pagination-wh pagination-left">
${c.audit_logs.pager('$link_previous ~2~ $link_next')}
</div>
%else:
${_('No actions yet')}
%endif