##// END OF EJS Templates
goto-switcher: optimized performance and query capabilities....
goto-switcher: optimized performance and query capabilities. - Previous implementation had on significant bug. The use of LIMIT 20 was limiting results BEFORE auth checks. In case of large ammount of similarly named repositories user didn't had access too, the result goto search was empty. This was becuase first 20 items fetched didn't pass permission checks and final auth list was empty. To fix this we now use proper filtering for auth using SQL. It means we first check user allowed repositories, and add this as a filter so end result from database is already to only the accessible repositories.

File last commit:

r1990:32399c6a default
r2038:2bdf9d4d default
Show More
new.mako
66 lines | 2.6 KiB | application/x-mako | MakoHtmlLexer
## -*- coding: utf-8 -*-
<%inherit file="base.mako"/>
<%namespace name="widgets" file="/widgets.mako"/>
<%def name="breadcrumbs_links()">
%if c.repo:
${h.link_to('Settings',h.route_path('edit_repo', repo_name=c.repo.repo_name))}
&raquo;
${h.link_to(_('Integrations'),request.route_url(route_name='repo_integrations_home', repo_name=c.repo.repo_name))}
%elif c.repo_group:
${h.link_to(_('Admin'),h.route_path('admin_home'))}
&raquo;
${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
&raquo;
${h.link_to(c.repo_group.group_name,h.url('edit_repo_group', group_name=c.repo_group.group_name))}
&raquo;
${h.link_to(_('Integrations'),request.route_url(route_name='repo_group_integrations_home', repo_group_name=c.repo_group.group_name))}
%else:
${h.link_to(_('Admin'),h.route_path('admin_home'))}
&raquo;
${h.link_to(_('Settings'),h.url('admin_settings'))}
&raquo;
${h.link_to(_('Integrations'),request.route_url(route_name='global_integrations_home'))}
%endif
&raquo;
${_('Create new integration')}
</%def>
<%widgets:panel class_='integrations'>
<%def name="title()">
%if c.repo:
${_('Create New Integration for repository: {repo_name}').format(repo_name=c.repo.repo_name)}
%elif c.repo_group:
${_('Create New Integration for repository group: {repo_group_name}').format(repo_group_name=c.repo_group.group_name)}
%else:
${_('Create New Global Integration')}
%endif
</%def>
%for integration, IntegrationType in c.available_integrations.items():
<%
if c.repo:
create_url = request.route_path('repo_integrations_create',
repo_name=c.repo.repo_name,
integration=integration)
elif c.repo_group:
create_url = request.route_path('repo_group_integrations_create',
repo_group_name=c.repo_group.group_name,
integration=integration)
else:
create_url = request.route_path('global_integrations_create',
integration=integration)
%>
<a href="${create_url}" class="integration-box">
<%widgets:panel>
<h2>
<div class="integration-icon">
${IntegrationType.icon|n}
</div>
${IntegrationType.display_name}
</h2>
${IntegrationType.description or _('No description available')}
</%widgets:panel>
</a>
%endfor
<div style="clear:both"></div>
</%widgets:panel>