##// END OF EJS Templates
auth: don't break hashing in case of user with empty password....
auth: don't break hashing in case of user with empty password. In some cases such as LDAP user created via external scripts users might set the passwords to empty. The hashing uses the md5(password_hash) to store reference to detect password changes and forbid using the same password. In case of pure LDAP users this is not valid, and we shouldn't raise Errors in such case. This change makes it work for empty passwords now.

File last commit:

r1409:c1ce56be default
r2203:8a18c3c3 default
Show More
test_vcs_unavailable.py
59 lines | 2.5 KiB | text/x-python | PythonLexer
# -*- coding: utf-8 -*-
# Copyright (C) 2010-2017 RhodeCode GmbH
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License, version 3
# (only), as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# This program is dual-licensed. If you wish to learn more about the
# RhodeCode Enterprise Edition, including its added features, Support services,
# and proprietary license terms, please see https://rhodecode.com/licenses/
import mock
import pytest
@pytest.mark.usefixtures('autologin_user', 'app')
def test_vcs_available_returns_summary_page(app, backend):
url = '/{repo_name}'.format(repo_name=backend.repo.repo_name)
response = app.get(url)
assert response.status_code == 200
assert 'Summary' in response.body
@pytest.mark.usefixtures('autologin_user', 'app')
def test_vcs_unavailable_returns_vcs_error_page(app, backend, app_settings):
from rhodecode.lib.vcs.exceptions import VCSCommunicationError
from rhodecode.lib.middleware.error_handling import (
PylonsErrorHandlingMiddleware)
# Depending on the used VCSServer protocol we have to patch a different
# RemoteRepo class to raise an exception. For the test it doesn't matter
# if http is used, it just requires the exception to be raised.
vcs_protocol = app_settings['vcs.server.protocol']
if vcs_protocol == 'http':
from rhodecode.lib.vcs.client_http import RemoteRepo
else:
pytest.fail('Unknown VCS server protocol: "{}"'.format(vcs_protocol))
url = '/{repo_name}'.format(repo_name=backend.repo.repo_name)
# Patch remote repo to raise an exception instead of making a RPC.
with mock.patch.object(RemoteRepo, '__getattr__') as remote_mock:
remote_mock.side_effect = VCSCommunicationError()
# Patch pylons error handling middleware to not re-raise exceptions.
with mock.patch.object(PylonsErrorHandlingMiddleware, 'reraise') as r:
r.return_value = False
response = app.get(url, expect_errors=True)
assert response.status_code == 502
assert 'Could not connect to VCS Server' in response.body