##// END OF EJS Templates
Display exception notes in tracebacks (#14039)...
Display exception notes in tracebacks (#14039) [PEP 678](https://peps.python.org/pep-0678/) introduced the ability to add notes to exception objects. This has been [released in Python 3.11](https://docs.python.org/3/library/exceptions.html#BaseException.add_note) and is currently not implemented in IPython. These changes are fully compatible with older Python versions that don't include PEP 678. Here's a sample test that shows the consistency in Python's stdlib traceback module (test 1) and the difference between Python and IPython's runtimes (test 2): ```python import traceback print('--- test 1 ---') try: raise Exception('Testing notes') except Exception as e: e.add_note('Does this work?') e.add_note('Yes!') traceback.print_exc() print('\n--- test 2 ---') try: raise Exception('Testing notes') except Exception as e: e.add_note('Does this work?') e.add_note('No!') raise ``` When executed with Python 3.11, both notes are displayed in both tracebacks: ``` $ python test.py --- test 1 --- Traceback (most recent call last): File "/app/test.py", line 5, in <module> raise Exception('Testing notes') Exception: Testing notes Does this work? Yes! --- test 2 --- Traceback (most recent call last): File "/app/test.py", line 13, in <module> raise Exception('Testing notes') Exception: Testing notes Does this work? No! ``` In IPython's VerboseTB does not yet handle exception notes: ``` $ ipython test.py --- test 1 --- Traceback (most recent call last): File "/app/test.py", line 5, in <module> raise Exception('Testing notes') Exception: Testing notes Does this work? Yes! --- test 2 --- --------------------------------------------------------------------------- Exception Traceback (most recent call last) File /app/test.py:13 11 print('\n--- test 2 ---') 12 try: ---> 13 raise Exception('Testing notes') 14 except Exception as e: 15 e.add_note('Does this work?') Exception: Testing notes ``` The changes I am suggesting are inspired from implementation of [Lib/traceback.py](https://github.com/python/cpython/blob/main/Lib/traceback.py) (search for `__notes__`) and improvements for dealing with edge cases more nicely in [cpython#103897](https://github.com/python/cpython/pull/103897). Although notes are meant to be strings only, I kept some inspiration from the existing exception handling to ensure that the notes are uncolored and bytes decoded, if there are any. I am definitely open to using a different color if deemed better. For context, `bpython` keeps the notes uncolored, and [Python's tutorial](https://docs.python.org/3/tutorial/errors.html#enriching-exceptions-with-notes) puts them in light gray, like the line numbers. Here's how the test 2 looks like after these changes: ![image](https://user-images.githubusercontent.com/16963011/234723689-6bbfe0ff-94d4-4a90-9da6-acfe1c8e5edf.png) ## :snake: :man_juggling:

File last commit:

r26498:7c853204
r28313:1d4e1847 merge
Show More
events.py
161 lines | 5.2 KiB | text/x-python | PythonLexer
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 """Infrastructure for registering and firing callbacks on application events.
Thomas Kluyver
Add docstrings for callbacks
r15599
Unlike :mod:`IPython.core.hooks`, which lets end users set single functions to
be called at specific times, or a collection of alternative methods to try,
callbacks are designed to be used by extension authors. A number of callbacks
can be registered for the same event without needing to be aware of one another.
The functions defined in this module are no-ops indicating the names of available
events and the arguments which will be passed to them.
Thomas Kluyver
Add note about experimental API
r15606
.. note::
This API is experimental in IPython 2.0, and may be revised in future versions.
Thomas Kluyver
Add docstrings for callbacks
r15599 """
Thomas Kluyver
Start of new callback system
r15597
Fabio Niephaus
Use `backcall` and introduce `ExecutionRequest`
r23996 from backcall import callback_prototype
Fabio Niephaus
Ensure post event callbacks are always called....
r23982
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 class EventManager(object):
Thomas Kluyver
Add docstrings for callbacks
r15599 """Manage a collection of events and a sequence of callbacks for each.
This is attached to :class:`~IPython.core.interactiveshell.InteractiveShell`
Thomas Kluyver
Clarity fixes pointed out by @ellisonbg
r15609 instances as an ``events`` attribute.
Thomas Kluyver
Add note about experimental API
r15606
.. note::
This API is experimental in IPython 2.0, and may be revised in future versions.
Thomas Kluyver
Add docstrings for callbacks
r15599 """
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 def __init__(self, shell, available_events):
Thomas Kluyver
Add docstrings for callbacks
r15599 """Initialise the :class:`CallbackManager`.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Add docstrings for callbacks
r15599 Parameters
----------
shell
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 The :class:`~IPython.core.interactiveshell.InteractiveShell` instance
available_events
An iterable of names for callback events.
Thomas Kluyver
Add docstrings for callbacks
r15599 """
Thomas Kluyver
Start of new callback system
r15597 self.shell = shell
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 self.callbacks = {n:[] for n in available_events}
Thomas Kluyver
Start of new callback system
r15597
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 def register(self, event, function):
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 """Register a new event callback.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Add docstrings for callbacks
r15599 Parameters
----------
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 event : str
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 The event for which to register this callback.
Thomas Kluyver
Add docstrings for callbacks
r15599 function : callable
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 A function to be called on the given event. It should take the same
parameters as the appropriate callback prototype.
Thomas Kluyver
Add docstrings for callbacks
r15599 Raises
------
TypeError
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 If ``function`` is not callable.
Thomas Kluyver
Add docstrings for callbacks
r15599 KeyError
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 If ``event`` is not one of the known events.
Thomas Kluyver
Add docstrings for callbacks
r15599 """
Thomas Kluyver
Start of new callback system
r15597 if not callable(function):
raise TypeError('Need a callable, got %r' % function)
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 callback_proto = available_events.get(event)
Quentin Peter
Don't register the same callabck multiple times...
r26114 if function not in self.callbacks[event]:
self.callbacks[event].append(callback_proto.adapt(function))
Thomas Kluyver
Start of new callback system
r15597
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 def unregister(self, event, function):
Thomas Kluyver
Add docstrings for callbacks
r15599 """Remove a callback from the given event."""
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 if function in self.callbacks[event]:
return self.callbacks[event].remove(function)
# Remove callback in case ``function`` was adapted by `backcall`.
for callback in self.callbacks[event]:
Thomas A Caswell
FIX: bare functions in callback registry on bogus unregister...
r24005 try:
if callback.__wrapped__ is function:
return self.callbacks[event].remove(callback)
except AttributeError:
pass
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997
raise ValueError('Function {!r} is not registered as a {} callback'.format(function, event))
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 def trigger(self, event, *args, **kwargs):
"""Call callbacks for ``event``.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Add docstrings for callbacks
r15599 Any additional arguments are passed to all callbacks registered for this
event. Exceptions raised by callbacks are caught, and a message printed.
"""
Craig Citro
Make event triggering robust to (un)registration....
r22317 for func in self.callbacks[event][:]:
Thomas Kluyver
Start of new callback system
r15597 try:
func(*args, **kwargs)
jsnydes
address #11630 by catching KeyboardInterrupt from event handlers
r24961 except (Exception, KeyboardInterrupt):
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 print("Error in callback {} (for {}):".format(func, event))
Thomas Kluyver
Start of new callback system
r15597 self.shell.showtraceback()
Thomas Kluyver
Add docstrings for callbacks
r15599 # event_name -> prototype mapping
Thomas Kluyver
Rename callbacks -> events (mostly), fire -> trigger
r15605 available_events = {}
Thomas Kluyver
Add docstrings for callbacks
r15599
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 def _define_event(callback_function):
callback_proto = callback_prototype(callback_function)
available_events[callback_function.__name__] = callback_proto
Thomas Kluyver
Start of new callback system
r15597 return callback_proto
Thomas Kluyver
Add docstrings for callbacks
r15599 # ------------------------------------------------------------------------------
# Callback prototypes
#
# No-op functions which describe the names of available events and the
# signatures of callbacks for those events.
# ------------------------------------------------------------------------------
Thomas Kluyver
Clarity fixes pointed out by @ellisonbg
r15609 @_define_event
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 def pre_execute():
Thomas Kluyver
Start of new callback system
r15597 """Fires before code is executed in response to user/frontend action.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Mention silent execution in docstrings
r15627 This includes comm and widget messages and silent execution, as well as user
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 code cells.
"""
Thomas Kluyver
Start of new callback system
r15597 pass
Thomas Kluyver
Clarity fixes pointed out by @ellisonbg
r15609 @_define_event
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 def pre_run_cell(info):
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 """Fires before user-entered code runs.
Thomas Kluyver
Start of new callback system
r15597
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 Parameters
----------
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 info : :class:`~IPython.core.interactiveshell.ExecutionInfo`
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 An object containing information used for the code execution.
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 """
Thomas Kluyver
Deprecate some hooks in favour of callbacks
r15602 pass
Thomas Kluyver
Clarity fixes pointed out by @ellisonbg
r15609 @_define_event
Fabio Niephaus
Rename ExecutionRequest to ExecutionInfo; refactor
r23997 def post_execute():
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 """Fires after code is executed in response to user/frontend action.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Fabio Niephaus
Add support for "finally" event callbacks....
r23909 This includes comm and widget messages and silent execution, as well as user
code cells.
"""
pass
@_define_event
Fabio Niephaus
Ensure post event callbacks are always called....
r23982 def post_run_cell(result):
"""Fires after user-entered code runs.
Fabio Niephaus
Add support for "finally" event callbacks....
r23909
Parameters
----------
result : :class:`~IPython.core.interactiveshell.ExecutionResult`
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 The object which will be returned as the execution result.
Fabio Niephaus
Add support for "finally" event callbacks....
r23909 """
pass
@_define_event
Thomas Kluyver
Use silly American spelling for initialised
r15612 def shell_initialized(ip):
Thomas Kluyver
Deprecate some hooks in favour of callbacks
r15602 """Fires after initialisation of :class:`~IPython.core.interactiveshell.InteractiveShell`.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Deprecate some hooks in favour of callbacks
r15602 This is before extensions and startup scripts are loaded, so it can only be
set by subclassing.
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498
Thomas Kluyver
Document new callbacks system
r15604 Parameters
----------
ip : :class:`~IPython.core.interactiveshell.InteractiveShell`
Matthias Bussonnier
DOC: More autoreformatting of docstrings....
r26498 The newly initialised shell.
Thomas Kluyver
Deprecate some hooks in favour of callbacks
r15602 """
pass