##// END OF EJS Templates
Refuse to install event loop hooks when not using `prompt_toolkit` (#14132)...
Refuse to install event loop hooks when not using `prompt_toolkit` (#14132) Without this, `%gui` is effectively a no-op but the user thinks it works. For example. If running `ipython`: ``` In [1]: import matplotlib; matplotlib.use('QtAgg'); from matplotlib import pyplot; pyplot.ion(); pyplot.plot([1, 2, 3, 4]) Installed qt6 event loop hook. Out[1]: [<matplotlib.lines.Line2D at 0x1ba2f59d2a0>] ``` The window appears and responds as expected. If running `ipython --simple-prompt`, the user would see the same output, when in fact no event loop hook was installed since it's not supported without `prompt_toolkit`. The resulting Qt window is unresponsive because the event loop is not running, i.e. with `--simple-prompt`, Qt windows should block (but `pyplot` doesn't/can't know to do that) With this PR, the user will see: ``` In [1]: import matplotlib; matplotlib.use('QtAgg'); from matplotlib import pyplot; pyplot.ion(); pyplot.plot([1, 2, 3, 4]) Cannot install event loop hook for "qt" when running with `--simple-prompt`. NOTE: Tk is supported natively; use Tk apps and Tk backends with `--simple-prompt`. Out[1]: [<matplotlib.lines.Line2D at 0x170be0c0310>] ``` They'll still get an unresponsive Qt window, but they'll at least be told this can't work (while anything using Tk will work just fine).

File last commit:

r27453:90fdcaf8
r28368:22fc5ab5 merge
Show More
shimmodule.py
89 lines | 2.6 KiB | text/x-python | PythonLexer
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851 """A shim module for deprecated imports
"""
# Copyright (c) IPython Development Team.
# Distributed under the terms of the Modified BSD License.
Nikita Kniazev
ShimImporter: implement modern interface
r27078 import importlib.abc
import importlib.util
Min RK
add import hook for shim packages...
r20990 import sys
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851 import types
Diego Garcia
use `import_module` instead of `__import__` ( FIX #10008 )
r22954 from importlib import import_module
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851
Min RK
use import_item in ShimModule...
r20991 from .importstring import import_item
Diego Garcia
use `import_module` instead of `__import__` ( FIX #10008 )
r22954
Min RK
add ShimWarning for shimmed imports...
r21515 class ShimWarning(Warning):
"""A warning to show when a module has moved, and a shim is in its place."""
Min RK
add import hook for shim packages...
r20990
Nikita Kniazev
ShimImporter: implement modern interface
r27078
class ShimImporter(importlib.abc.MetaPathFinder):
Min RK
add import hook for shim packages...
r20990 """Import hook for a shim.
Nikita Kniazev
ShimImporter: implement modern interface
r27078
Min RK
add import hook for shim packages...
r20990 This ensures that submodule imports return the real target module,
not a clone that will confuse `is` and `isinstance` checks.
"""
def __init__(self, src, mirror):
self.src = src
self.mirror = mirror
Nikita Kniazev
ShimImporter: implement modern interface
r27078
Min RK
add import hook for shim packages...
r20990 def _mirror_name(self, fullname):
"""get the name of the mirrored module"""
Nikita Kniazev
ShimImporter: implement modern interface
r27078 return self.mirror + fullname[len(self.src) :]
def find_spec(self, fullname, path, target=None):
if fullname.startswith(self.src + "."):
Min RK
add import hook for shim packages...
r20990 mirror_name = self._mirror_name(fullname)
Nikita Kniazev
ShimImporter: implement modern interface
r27078 return importlib.util.find_spec(mirror_name)
Min RK
add import hook for shim packages...
r20990
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851 class ShimModule(types.ModuleType):
def __init__(self, *args, **kwargs):
self._mirror = kwargs.pop("mirror")
Min RK
add import hook for shim packages...
r20990 src = kwargs.pop("src", None)
if src:
kwargs['name'] = src.rsplit('.', 1)[-1]
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851 super(ShimModule, self).__init__(*args, **kwargs)
Min RK
add import hook for shim packages...
r20990 # add import hook for descendent modules
if src:
sys.meta_path.append(
ShimImporter(src=src, mirror=self._mirror)
)
@property
def __path__(self):
return []
Min RK
Don't import mirror for `__spec__` until requested...
r20953 @property
def __spec__(self):
"""Don't produce __spec__ until requested"""
Diego Garcia
use `import_module` instead of `__import__` ( FIX #10008 )
r22954 return import_module(self._mirror).__spec__
Min RK
ensure `__all__` and `__dir__` are defined on shims...
r21311
def __dir__(self):
Diego Garcia
use `import_module` instead of `__import__` ( FIX #10008 )
r22954 return dir(import_module(self._mirror))
Min RK
ensure `__all__` and `__dir__` are defined on shims...
r21311
@property
def __all__(self):
"""Ensure __all__ is always defined"""
Diego Garcia
use `import_module` instead of `__import__` ( FIX #10008 )
r22954 mod = import_module(self._mirror)
Min RK
ensure `__all__` and `__dir__` are defined on shims...
r21311 try:
return mod.__all__
except AttributeError:
return [name for name in dir(mod) if not name.startswith('_')]
Thomas Kluyver
Add shim to preserve IPython.qt imports
r20851
def __getattr__(self, key):
# Use the equivalent of import_item(name), see below
name = "%s.%s" % (self._mirror, key)
Min RK
use import_item in ShimModule...
r20991 try:
return import_item(name)
Ram Rachum
Fix exception causes all over the codebase
r25833 except ImportError as e:
raise AttributeError(key) from e
Jochen Ott
Add fallback for utils.ShimModule.__repr__
r27453
def __repr__(self):
# repr on a module can be called during error handling; make sure
# it does not fail, even if the import fails
try:
return self.__getattr__("__repr__")()
except AttributeError:
return f"<ShimModule for {self._mirror!r}>"