##// END OF EJS Templates
Remove EventManager reset methods, because they violate encapsulation....
Remove EventManager reset methods, because they violate encapsulation. The whole idea of the EventManager is that you can register hooks without worrying about what hooks other pieces of code might be registering. The reset methods violate this separation of concerns, since they will blow away everyone else's hooks too. (See gh-6680 for an example of this breaking things.) Since there is never any safe way to use them, we simply remove them entirely.

File last commit:

r17535:920c0ba6
r18547:4043b271
Show More
kernellist.js
52 lines | 1.5 KiB | application/javascript | JavascriptLexer
Jonathan Frederic
Finished making tree.html requirejs friendly
r17190 // Copyright (c) IPython Development Team.
// Distributed under the terms of the Modified BSD License.
define([
'base/js/namespace',
Jonathan Frederic
MWE,...
r17200 'jquery',
Jonathan Frederic
Finished making tree.html requirejs friendly
r17190 'tree/js/notebooklist',
Jonathan Frederic
Fix imports of "modules",...
r17202 ], function(IPython, $, notebooklist) {
Paul Ivanov
minimal KernelList
r15382 "use strict";
jon
In person review with @ellisonbg
r17210 var KernelList = function (selector, options) {
jon
Added some nice comments,...
r17211 // Constructor
//
// Parameters:
// selector: string
// options: dictionary
// Dictionary of keyword arguments.
// session_list: SessionList instance
// base_url: string
// notebook_path: string
jon
In person review with @ellisonbg
r17210 notebooklist.NotebookList.call(this, selector, $.extend({
MinRK
updates per review...
r17535 element_name: 'running'},
jon
In person review with @ellisonbg
r17210 options));
Paul Ivanov
minimal KernelList
r15382 };
Jonathan Frederic
Fix all the bugs!
r17203 KernelList.prototype = Object.create(notebooklist.NotebookList.prototype);
Paul Ivanov
minimal KernelList
r15382
Paul Ivanov
ok, Running tab is working now
r15454 KernelList.prototype.sessions_loaded = function (d) {
Paul Ivanov
added IPython.session_list...
r15479 this.sessions = d;
Paul Ivanov
ok, Running tab is working now
r15454 this.clear_list();
MinRK
updates per review...
r17535 var item, path_name;
for (path_name in d) {
if (!d.hasOwnProperty(path_name)) {
// nothing is safe in javascript
continue;
}
item = this.new_item(-1);
this.add_link({
name: path_name,
path: '',
type: 'notebook',
}, item);
this.add_shutdown_button(item, this.sessions[path_name]);
Paul Ivanov
ok, Running tab is working now
r15454 }
Paul Ivanov
use explicit running header name + jquery's toggle
r15512 $('#running_list_header').toggle($.isEmptyObject(d));
Jonathan Frederic
Finished making tree.html requirejs friendly
r17190 };
Paul Ivanov
ok, Running tab is working now
r15454
Jonathan Frederic
Finished making tree.html requirejs friendly
r17190 // Backwards compatability.
Paul Ivanov
minimal KernelList
r15382 IPython.KernelList = KernelList;
Jonathan Frederic
Return dicts instead of classes,...
r17201 return {'KernelList': KernelList};
Jonathan Frederic
Finished making tree.html requirejs friendly
r17190 });