upstream/ipython Files · IPython/html/tests/notebook/empty_arrow_keys.js

Backport PR : Changed right arrow key movement function to mirror left arrow key...

Backport PR : Changed right arrow key movement function to mirror left arrow key Seems to solve Issue on this machine, and passing the test file locally. Changed from `cursor.movePosition` to `self._control.moveCursor`, the latter is what the left-arrow key uses. Also removed line 1373 which seems unnecessary and which prevents the cursor from moving at all. I'm not certain how to further test this to make sure nothing was broken.

Jonathan Frederic - - Load All Authors

File last commit:

r15940:36e09c7c


                r17151:477b3912

Download file

             empty_arrow_keys.js
        
                    21 lines
            
             | 598 B
            
                | application/javascript
            
             |
                JavascriptLexer
            
             / IPython / html / tests / notebook / empty_arrow_keys.js
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        David Wyde
    
Add a test to demonstrate errors when up/down arrow keys are...

              r13251
            
      //

      // Check for errors with up and down arrow presses in an empty notebook.

      //

        Paul Ivanov
    
pep8 style function names

              r13275
            
      casper.notebook_test(function () {

        David Wyde
    
Add a test to demonstrate errors when up/down arrow keys are...

              r13251
            
          var result = this.evaluate(function() {

        Paul Ivanov
    
make confusing code snippet more readable

              r13283
            
              var ncells = IPython.notebook.ncells();

              var i;

        David Wyde
    
Add a test to demonstrate errors when up/down arrow keys are...

              r13251
            
              // Delete all cells.

              for (i = 0; i < ncells; i++) {

                  IPython.notebook.delete_cell();

              }

        Jonathan Frederic
    
Partial fix of problems b/c keydown move

              r15940
            
        David Wyde
    
Add a test to demonstrate errors when up/down arrow keys are...

              r13251
            
              return true;

          });

        Jonathan Frederic
    
Partial fix of problems b/c keydown move

              r15940
            
          // Simulate the "up arrow" and "down arrow" keys.

          this.trigger_keydown('up');

          this.trigger_keydown('down');

        David Wyde
    
Wrap CasperJS tests in a helper function to reduce boilerplate.

              r13253
            
          this.test.assertTrue(result, 'Up/down arrow okay in empty notebook.');

        David Wyde
    
Add a test to demonstrate errors when up/down arrow keys are...

              r13251
            
      });

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

David Wyde Add a test to demonstrate errors when up/down arrow keys are...	r13251	//
		// Check for errors with up and down arrow presses in an empty notebook.
		//
Paul Ivanov pep8 style function names	r13275	casper.notebook_test(function () {
David Wyde Add a test to demonstrate errors when up/down arrow keys are...	r13251	var result = this.evaluate(function() {
Paul Ivanov make confusing code snippet more readable	r13283	var ncells = IPython.notebook.ncells();
		var i;
David Wyde Add a test to demonstrate errors when up/down arrow keys are...	r13251
		// Delete all cells.
		for (i = 0; i < ncells; i++) {
		IPython.notebook.delete_cell();
		}
Jonathan Frederic Partial fix of problems b/c keydown move	r15940
David Wyde Add a test to demonstrate errors when up/down arrow keys are...	r13251	return true;
		});
Jonathan Frederic Partial fix of problems b/c keydown move	r15940
		// Simulate the "up arrow" and "down arrow" keys.
		this.trigger_keydown('up');
		this.trigger_keydown('down');
David Wyde Wrap CasperJS tests in a helper function to reduce boilerplate.	r13253	this.test.assertTrue(result, 'Up/down arrow okay in empty notebook.');
David Wyde Add a test to demonstrate errors when up/down arrow keys are...	r13251	});