##// END OF EJS Templates
upstream » ipython
RSS

Clone from https://github.com/ipython/ipython.git

Reset the interactive namespace __warningregistry__ before executing code...
Reset the interactive namespace __warningregistry__ before executing code Fixes #6611. Idea: Right now, people often don't see important warnings when running code in IPython, because (to a first approximation) any given warning will only issue once per session. Blink and you'll miss it! This is a very common contributor to confused emails to numpy-discussion. E.g.: In [5]: 1 / my_array_with_random_contents /home/njs/.user-python2.7-64bit-3/bin/ipython:1: RuntimeWarning: divide by zero encountered in divide #!/home/njs/.user-python2.7-64bit-3/bin/python Out[5]: array([ 1.77073316, -2.29765021, -2.01800811, ..., 1.13871243, -1.08302964, -8.6185091 ]) Oo, right, guess I gotta be careful of those zeros -- thanks, numpy, for giving me that warning! A few days later: In [592]: 1 / some_other_array Out[592]: array([ 3.07735763, 0.50769289, 0.83984078, ..., -0.67563917, -0.85736257, -1.36511271]) Oops, it turns out that this array had a zero in it too, and that's going to bite me later. But no warning this time! The effect of this commit is to make it so that warnings triggered by the code in cell 5 do *not* suppress warnings triggered by the code in cell 592. Note that this only applies to warnings triggered *directly* by code entered interactively -- if somepkg.foo() calls anotherpkg.bad_func() which issues a warning, then this warning will still only be displayed once, even if multiple cells call somepkg.foo(). But if cell 5 and cell 592 both call anotherpkg.bad_func() directly, then both will get warnings. (Important exception: if foo() is defined *interactively*, and calls anotherpkg.bad_func(), then every cell that calls foo() will display the warning again. This is unavoidable without fixes to CPython upstream.) Explanation: Python's warning system has some weird quirks. By default, it tries to suppress duplicate warnings, where "duplicate" means the same warning message triggered twice by the same line of code. This requires determining which line of code is responsible for triggering a warning, and this is controlled by the stacklevel= argument to warnings.warn. Basically, though, the idea is that if foo() calls bar() which calls baz() which calls some_deprecated_api(), then baz() will get counted as being "responsible", and the warning system will make a note that the usage of some_deprecated_api() inside baz() has already been warned about and doesn't need to be warned about again. So far so good. To accomplish this, obviously, there has to be a record of somewhere which line this was. You might think that this would be done by recording the filename:linenumber pair in a dict inside the warnings module, or something like that. You would be wrong. What actually happens is that the warnings module will use stack introspection to reach into baz()'s execution environment, create a global (module-level) variable there named __warningregistry__, and then, inside this dictionary, record just the line number. Basically, it assumes that any given module contains only one line 1, only one line 2, etc., so storing the filename is irrelevant. Obviously for interactive code this is totally wrong -- all cells share the same execution environment and global namespace, and they all contain a new line 1. Currently the warnings module treats these as if they were all the same line. In fact they are not the same line; once we have executed a given chunk of code, we will never see those particular lines again. As soon as a given chunk of code finishes executing, its line number labels become meaningless, and the corresponding warning registry entries become meaningless as well. Therefore, with this patch we delete the __warningregistry__ each time we execute a new block of code.
Jessica B. Hamrick - - Load All Authors

File last commit:

r16345:f2132cdc
r18548:61431d7d
Show More
MANIFEST.in
39 lines | 809 B | text/plain | TextLexer
/ MANIFEST.in
History | Source | Raw |Copy content |Copy permalink
Fernando Perez
Minor doc updates, ensure README is in final tarball.
 r6599 include README.rst
Jonathan Frederic
s/COPYING.txt/COPYING.rst
 r15990 include COPYING.rst
Fernando Perez
Fixes to build system.
 r1522 include setupbase.py
Brian Granger
Fixes in MANIFEST.in and ipcontroller.py...
 r1727 include setupegg.py
Ville M. Vainio
more crlf
 r1033
graft setupext
Brian Granger
Fixing a few bugs to get the win32 installer working again.
 r2060 graft scripts
MinRK
update MANIFEST.in...
 r4169
Fernando Perez
Ignore local static copy of mathjax in MANIFEST
 r5005 # Load main dir but exclude things we don't want in the distro
MinRK
update MANIFEST.in...
 r4169 graft IPython
MinRK
update references for IPython.html
 r11035 prune IPython/html/static/mathjax
Brian E Granger
Finished initial reworking and updating of setup.py and friends, including the MANIFEST.in. Everything seems...
 r1244
Fernando Perez
Fix missing files in MANIFEST.in causing setup from sdist to fail.
 r5176 # Include some specific files and data resources we need
Fernando Perez
Add support for commit information in auto-generated archives....
 r3199 include IPython/.git_commit_info.ini
MinRK
update frontend in MANIFEST and .gitignore
 r11030 include IPython/qt/console/resources/icon/IPythonConsole.svg
Jessica B. Hamrick
Update MANIFEST to include schema json file
 r16345 include IPython/nbformat/v3/v3.withref.json
Fernando Perez
Add SVG qt console icon to package data.
 r5160
Fernando Perez
Fix missing files in MANIFEST.in causing setup from sdist to fail.
 r5176 # Documentation
Brian E Granger
Fixed setupbase.py and MANIFEST.in to reflect all the changes to docs. Currently,...
 r1259 graft docs
exclude docs/\#*
MinRK
exclude gzipped manpages from sdist
 r6611 exclude docs/man/*.1.gz
Ville M. Vainio
docs: remove build crap from sdist with manifest.in
 r1192
Brian Granger
Updating MANIFEST.in for new examples location.
 r9192 # Examples
graft examples
Fernando Perez
Fixes to build/setup machinery....
 r1525 # docs subdirs we want to skip
prune docs/build
MinRK
update MANIFEST.in...
 r4169 prune docs/gh-pages
MinRK
don't build sphinx docs for sdist
 r6145 prune docs/dist
Ville M. Vainio
more crlf
 r1033
Fernando Perez
Fix missing files in MANIFEST.in causing setup from sdist to fail.
 r5176 # Patterns to exclude from any directory
Ville M. Vainio
more crlf
 r1033 global-exclude *~
global-exclude *.flc
global-exclude *.pyc
Fernando Perez
Fix missing files in MANIFEST.in causing setup from sdist to fail.
 r5176 global-exclude *.pyo
Ville M. Vainio
more crlf
 r1033 global-exclude .dircopy.log
MinRK
exclude `.git`...
 r12201 global-exclude .git
MinRK
exclude notebook checkpoints from manifest
 r15028 global-exclude .ipynb_checkpoints