##// END OF EJS Templates
upstream » ipython
RSS

Clone from https://github.com/ipython/ipython.git

Backport PR #2294: inputhook_qt4: Use QEventLoop instead of starting up the QCoreApplication...
Backport PR #2294: inputhook_qt4: Use QEventLoop instead of starting up the QCoreApplication I referenced this branch in #2080 and was letting it sit for a little while, but I have decided to make it a full pull request to get some additional visibility. Essentially our Qt event loop mechanism repeatedly starts and quits a `QCoreApplication` object. Unfortunately the `QCoreApplication::quit` slot has a lot of unintended side effects (like emitting an `aboutToQuit` signal which closes all open file dialogs). For our input hook, we _might_ be able to get by with just using a `QEventLoop` whose quit slot is much simpler and less destructive. For a little bit of background on why one might want to just use `QEventLoop::exec`, let's examine what `QCoreApplication::exec` does: ```c++ int QCoreApplication::exec() { if (!QCoreApplicationPrivate::checkInstance("exec")) return -1; // ... [some assertions] threadData->quitNow = false; QEventLoop eventLoop; self->d_func()->in_exec = true; self->d_func()->aboutToQuitEmitted = false; int returnCode = eventLoop.exec(); threadData->quitNow = false; if (self) { self->d_func()->in_exec = false; if (!self->d_func()->aboutToQuitEmitted) emit self->aboutToQuit(); self->d_func()->aboutToQuitEmitted = true; sendPostedEvents(0, QEvent::DeferredDelete); } return returnCode; } ``` As far as I can tell, it's a small wrapper around `QEventLoop::exec` which also: * Sets some variables regarding the current status * Emits an `aboutToQuit` signal right before the function returns (which is the root cause of @denisri's problem in #2080). Historically, our Qt event loop is a python implementation of the (win 32) input hook supplied with the PyQt4 source (see qtcore_input_hook` in `python-qt4/sip/QtCore/qcoreapplication.sip`), which more or less dates to a [mailing list post](http://www.riverbankcomputing.com/pipermail/pyqt/2007-July/016512.html) from July 2007.
Fernando Perez - - Load All Authors

File last commit:

r5076:18fd00d4
r9834:71196839
Show More
ipython.css
40 lines | 1.6 KiB | text/css | CssLexer
/ IPython / frontend / html / notebook / static / codemirror / theme / ipython.css
History | Source | Raw |Copy content |Copy permalink
Brian E. Granger
Updating CodeMirror to v 2.12....
 r4504
.cm-s-ipython span.cm-keyword {color: #008000; font-weight: bold;}
Fernando Perez
Match number color in code cells to numbers of input prompts.
 r5076 .cm-s-ipython span.cm-number {color: #000080;}
Brian E. Granger
Updating CodeMirror to v 2.12....
 r4504 .cm-s-ipython span.cm-operator {color: #AA22FF; font-weight: bold;}
.cm-s-ipython span.cm-meta {color: #AA22FF;}
.cm-s-ipython span.cm-comment {color: #408080; font-style: italic;}
.cm-s-ipython span.cm-string {color: #BA2121;}
.cm-s-ipython span.cm-error {color: #f00;}
.cm-s-ipython span.cm-builtin {color: #008000;}
.cm-s-ipython span.cm-variable {color: #000000;}
/* These classes are not currently used in the python.js mode */
/*.cm-s-ipython span.cm-atom {color: #219;}*/
/*.cm-s-ipython span.cm-def {color: #00f;}*/
/*.cm-s-ipython span.cm-variable-2 {color: #05a;}*/
/*.cm-s-ipython span.cm-variable-3 {color: #0a5;}*/
/*.cm-s-ipython span.cm-property {color: black;}*/
/*.cm-s-ipython span.cm-qualifier {color: #555;}*/
/*.cm-s-ipython span.cm-bracket {color: #cc7;}*/
/*.cm-s-ipython span.cm-tag {color: #170;}*/
/*.cm-s-ipython span.cm-attribute {color: #00c;}*/
/* These are the old styles for our pre-themed version */
/*span.py-delimiter {color: #666666;}*/
/*span.py-special {color: #666666;}*/
/*span.py-operator {color: #AA22FF; font-weight: bold;}*/
/*span.py-keyword {color: #008000; font-weight: bold;}*/
/*span.py-number {color: #666666;}*/
/*span.py-identifier {color: #000000;}*/
/*span.py-func {color: #000000;}*/
/*span.py-type {color: #008000;}*/
/*span.py-decorator {color: #AA22FF;}*/
/*span.py-comment {color: #408080; font-style: italic;}*/
/*span.py-string {color: #BA2121;}*/
/*span.py-bytes {color: #BA2121;}*/
/*span.py-raw {color: #BA2121;}*/
/*span.py-unicode {color: #BA2121;}*/