upstream/ipython Files · IPython/core/tests/test_events.py

Fix and ...

Fix and The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

Nathaniel J. Smith - - Load All Authors

File last commit:

r18547:4043b271


                r20538:ae7f6d6a

Download file

             test_events.py
        
                    32 lines
            
             | 929 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_events.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
      import unittest

      try:  # Python 3.3 +

          from unittest.mock import Mock

      except ImportError:

          from mock import Mock

        Thomas Kluyver
    
Rename callbacks -> events (mostly), fire -> trigger

              r15605
            
      from IPython.core import events

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
      import IPython.testing.tools as tt

      def ping_received():

          pass

      class CallbackTests(unittest.TestCase):

          def setUp(self):

        Thomas Kluyver
    
Rename callbacks -> events (mostly), fire -> trigger

              r15605
            
              self.em = events.EventManager(get_ipython(), {'ping_received': ping_received})

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
          def test_register_unregister(self):

              cb = Mock()

        Thomas Kluyver
    
Rename callbacks -> events (mostly), fire -> trigger

              r15605
            
              self.em.register('ping_received', cb)        

              self.em.trigger('ping_received')

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
              self.assertEqual(cb.call_count, 1)

        Thomas Kluyver
    
Rename callbacks -> events (mostly), fire -> trigger

              r15605
            
              self.em.unregister('ping_received', cb)

              self.em.trigger('ping_received')

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
              self.assertEqual(cb.call_count, 1)

          def test_cb_error(self):

              cb = Mock(side_effect=ValueError)

        Thomas Kluyver
    
Rename callbacks -> events (mostly), fire -> trigger

              r15605
            
              self.em.register('ping_received', cb)

        Thomas Kluyver
    
Add tests for callback infrastructure

              r15601
            
              with tt.AssertPrints("Error in callback"):

        Nathaniel J. Smith
    
Remove EventManager reset methods, because they violate encapsulation....

              r18547
            
                  self.em.trigger('ping_received')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Thomas Kluyver Add tests for callback infrastructure	r15601	import unittest
		try: # Python 3.3 +
		from unittest.mock import Mock
		except ImportError:
		from mock import Mock

Thomas Kluyver Rename callbacks -> events (mostly), fire -> trigger	r15605	from IPython.core import events
Thomas Kluyver Add tests for callback infrastructure	r15601	import IPython.testing.tools as tt

		def ping_received():
		pass

		class CallbackTests(unittest.TestCase):
		def setUp(self):
Thomas Kluyver Rename callbacks -> events (mostly), fire -> trigger	r15605	self.em = events.EventManager(get_ipython(), {'ping_received': ping_received})
Thomas Kluyver Add tests for callback infrastructure	r15601
		def test_register_unregister(self):
		cb = Mock()

Thomas Kluyver Rename callbacks -> events (mostly), fire -> trigger	r15605	self.em.register('ping_received', cb)
		self.em.trigger('ping_received')
Thomas Kluyver Add tests for callback infrastructure	r15601	self.assertEqual(cb.call_count, 1)

Thomas Kluyver Rename callbacks -> events (mostly), fire -> trigger	r15605	self.em.unregister('ping_received', cb)
		self.em.trigger('ping_received')
Thomas Kluyver Add tests for callback infrastructure	r15601	self.assertEqual(cb.call_count, 1)

		def test_cb_error(self):
		cb = Mock(side_effect=ValueError)
Thomas Kluyver Rename callbacks -> events (mostly), fire -> trigger	r15605	self.em.register('ping_received', cb)
Thomas Kluyver Add tests for callback infrastructure	r15601	with tt.AssertPrints("Error in callback"):
Nathaniel J. Smith Remove EventManager reset methods, because they violate encapsulation....	r18547	self.em.trigger('ping_received')