##// END OF EJS Templates
Fix #4777 and #7887...
Fix #4777 and #7887 The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

File last commit:

r18289:9b8d831c
r20538:ae7f6d6a
Show More
codemirror-ipython.js
38 lines | 1.5 KiB | application/javascript | JavascriptLexer
/ IPython / html / static / notebook / js / codemirror-ipython.js
Matthias BUSSONNIER
Simplify codemirror ipython-mode...
r11242 // IPython mode is just a slightly altered Python Mode with `?` beeing a extra
// single operator. Here we define `ipython` mode in the require `python`
// callback to auto-load python mode, which is more likely not the best things
// to do, but at least the simple one for now.
Brian E. Granger
Updating ipython CM mode.
r10416
Matthias BUSSONNIER
Update to codemirror 4...
r18280 (function(mod) {
if (typeof exports == "object" && typeof module == "object"){ // CommonJS
Matthias Bussonnier
cleanup whitespace
r18289 mod(require("codemirror/lib/codemirror"),
Matthias BUSSONNIER
Update to codemirror 4...
r18280 require("codemirror/mode/python/python")
);
} else if (typeof define == "function" && define.amd){ // AMD
Matthias Bussonnier
cleanup whitespace
r18289 define(["codemirror/lib/codemirror",
Matthias BUSSONNIER
Update to codemirror 4...
r18280 "codemirror/mode/python/python"], mod);
} else {// Plain browser env
mod(CodeMirror);
}
})(function(CodeMirror) {
Matthias BUSSONNIER
"use strict" in most (if not all) our javascript...
r12103 "use strict";
Matthias Bussonnier
cleanup whitespace
r18289
Matthias BUSSONNIER
Simplify codemirror ipython-mode...
r11242 CodeMirror.defineMode("ipython", function(conf, parserConf) {
Jason Grout
Copy codemirror mode configuration instead of changing it...
r17543 var pythonConf = {};
for (var prop in parserConf) {
if (parserConf.hasOwnProperty(prop)) {
pythonConf[prop] = parserConf[prop];
}
}
pythonConf.name = 'python';
pythonConf.singleOperators = new RegExp("^[\\+\\-\\*/%&|\\^~<>!\\?]");
Brian E. Granger
Adding tests and limiting CM mode to python 3.
r17742 if (pythonConf.version === 3) {
pythonConf.identifiers = new RegExp("^[_A-Za-z\u00A1-\uFFFF][_A-Za-z0-9\u00A1-\uFFFF]*");
} else if (pythonConf.version === 2) {
pythonConf.identifiers = new RegExp("^[_A-Za-z][_A-Za-z0-9]*");
}
Jason Grout
Copy codemirror mode configuration instead of changing it...
r17543 return CodeMirror.getMode(conf, pythonConf);
Matthias BUSSONNIER
Simplify codemirror ipython-mode...
r11242 }, 'python');
Brian E. Granger
Copying CodeMirror's python mode into place for our ipython mode.
r10415
Matthias BUSSONNIER
Simplify codemirror ipython-mode...
r11242 CodeMirror.defineMIME("text/x-ipython", "ipython");
})