##// END OF EJS Templates
Major work on the documentation....
Major work on the documentation. * Everything is cleaned up. * Outdated things have been re-written or removed. * Full documentation about the new config system has been added. * The developer guide has been re-organized and re-written where appropriate.

File last commit:

r2277:dc983636
r2277:dc983636
Show More
coding_guide.txt
78 lines | 3.3 KiB | text/plain | TextLexer
Brian Granger
Major work on the documentation....
r2277 ============
Coding guide
============
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 General coding conventions
==========================
Fernando Perez
More doc updates....
r1754
In general, we'll try to follow the standard Python style conventions as
Brian Granger
Major work on the documentation....
r2277 described in Python's PEP 8 [PEP8]_, the official Python Style Guide.
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 Other general comments:
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 * In a large file, top level classes and functions should be separated by 2
Fernando Perez
More doc updates....
r1754 lines to make it easier to separate them visually.
Brian Granger
Major work on the documentation....
r2277 * Use 4 spaces for indentation, **never** use hard tabs.
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 * Keep the ordering of methods the same in classes that have the same methods.
Fernando Perez
More doc updates....
r1754 This is particularly true for classes that implement similar interfaces and
for interfaces that are similar.
Naming conventions
Brian Granger
Major work on the documentation....
r2277 ==================
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 In terms of naming conventions, we'll follow the guidelines of PEP 8 [PEP8]_.
Some of the existing code doesn't honor this perfectly, but for all new
IPython code (and much existing code is being refactored), we'll use:
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 * All ``lowercase`` module names.
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 * ``CamelCase`` for class names.
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 * ``lowercase_with_underscores`` for methods, functions, variables and
Fernando Perez
More doc updates....
r1754 attributes.
This may be confusing as some of the existing codebase uses a different
convention (``lowerCamelCase`` for methods and attributes). Slowly, we will
move IPython over to the new convention, providing shadow names for backward
compatibility in public interfaces.
There are, however, some important exceptions to these rules. In some cases,
IPython code will interface with packages (Twisted, Wx, Qt) that use other
conventions. At some level this makes it impossible to adhere to our own
standards at all times. In particular, when subclassing classes that use other
naming conventions, you must follow their naming conventions. To deal with
cases like this, we propose the following policy:
Brian Granger
Work on documentation....
r2276 * If you are subclassing a class that uses different conventions, use its
naming conventions throughout your subclass. Thus, if you are creating a
Twisted Protocol class, used Twisted's
``namingSchemeForMethodsAndAttributes.``
* All IPython's official interfaces should use our conventions. In some cases
this will mean that you need to provide shadow names (first implement
``fooBar`` and then ``foo_bar = fooBar``). We want to avoid this at all
costs, but it will probably be necessary at times. But, please use this
sparingly!
Implementation-specific *private* methods will use
Brian Granger
Major work on the documentation....
r2277 ``_single_underscore_prefix``. Names with a leading double underscore will
Brian Granger
Work on documentation....
r2276 *only* be used in special cases, as they makes subclassing difficult (such
names are not easily seen by child classes).
Occasionally some run-in lowercase names are used, but mostly for very short
names or where we are implementing methods very similar to existing ones in a
base class (like ``runlines()`` where ``runsource()`` and ``runcode()`` had
established precedent).
The old IPython codebase has a big mix of classes and modules prefixed with an
explicit ``IP``. In Python this is mostly unnecessary, redundant and frowned
upon, as namespaces offer cleaner prefixing. The only case where this approach
is justified is for classes which are expected to be imported into external
namespaces and a very generic name (like Shell) is too likely to clash with
Brian Granger
Major work on the documentation....
r2277 something else. However, if a prefix seems absolutely necessary the more
Brian Granger
Work on documentation....
r2276 specific ``IPY`` or ``ipy`` are preferred.
Fernando Perez
More doc updates....
r1754
Brian Granger
Major work on the documentation....
r2277 .. [PEP8] Python Enhancement Proposal 8. http://www.python.org/peps/pep-0008.html
Brian Granger
Cleanup of docs....
r2275