From 0f2a7ee3f4c1756ca8cee30c428b953fa8ea0fb0 2012-01-06 05:53:34
From: MinRK <benjaminrk@gmail.com>
Date: 2012-01-06 05:53:34
Subject: [PATCH] explicit for-loop in cleanup_kernels

makes single-iteration clearer than while loop, as reviewed by @fperez.

---

diff --git a/IPython/frontend/html/notebook/notebookapp.py b/IPython/frontend/html/notebook/notebookapp.py
index 4a24538..beb356b 100644
--- a/IPython/frontend/html/notebook/notebookapp.py
+++ b/IPython/frontend/html/notebook/notebookapp.py
@@ -367,8 +367,9 @@ class NotebookApp(BaseIPythonApplication):
         """
         self.log.info('Shutting down kernels')
         km = self.kernel_manager
-        while km.kernel_ids:
-            km.kill_kernel(km.kernel_ids[0])
+        # copy list, since kill_kernel deletes keys
+        for kid in list(km.kernel_ids):
+            km.kill_kernel(kid)
 
     def start(self):
         ip = self.ip if self.ip else '[all ip addresses on your system]'