From 10a376e04c5ed29a0fb2feb61d33f6ee3bb40f57 2015-04-10 17:37:04 From: Ian Barfield Date: 2015-04-10 17:37:04 Subject: [PATCH] fix bug in stale profile clean up for clusters "clusters" tab of my notebook wasn't rendering, so checked the log, found the stack trace: ``` [...] File "/usr/local/lib/python3.4/site-packages/ipython-3.0.0-py3.4.egg/IPython/html/services/clusters/handlers.py", line 21, in get self.finish(json.dumps(self.cluster_manager.list_profiles())) File "/usr/local/lib/python3.4/site-packages/ipython-3.0.0-py3.4.egg/IPython/html/services/clusters/clustermanager.py", line 77, in list_profiles self.update_profiles() File "/usr/local/lib/python3.4/site-packages/ipython-3.0.0-py3.4.egg/IPython/html/services/clusters/clustermanager.py", line 74, in update_profiles self.profiles.pop(stale) TypeError: unhashable type: 'set' ``` looks like a pretty straightforward mistake --- diff --git a/jupyter_notebook/services/clusters/clustermanager.py b/jupyter_notebook/services/clusters/clustermanager.py index c0a8776..6b82db6 100644 --- a/jupyter_notebook/services/clusters/clustermanager.py +++ b/jupyter_notebook/services/clusters/clustermanager.py @@ -71,7 +71,7 @@ class ClusterManager(LoggingConfigurable): for profile in stale: # remove profiles that no longer exist self.log.debug("Profile '%s' no longer exists", profile) - self.profiles.pop(stale) + self.profiles.pop(profile) def list_profiles(self): self.update_profiles()