From 19a55196b3d97183331ee3cfd7d2c755b5ba3ed3 2014-04-07 15:37:55
From: Pankaj Pandey <pankaj86@gmail.com>
Date: 2014-04-07 15:37:55
Subject: [PATCH] FileNotebookManager: Use shutil.move() instead of os.rename()

`os.rename()` fails in case the new path is on a different
filesystem. For example if a file in `/tmp` is tried to save
to home, it causes following error:

[Errno 18] Invalid cross-device link using os.rename

---

diff --git a/IPython/html/services/notebooks/filenbmanager.py b/IPython/html/services/notebooks/filenbmanager.py
index 8e99bc5..580c2f5 100644
--- a/IPython/html/services/notebooks/filenbmanager.py
+++ b/IPython/html/services/notebooks/filenbmanager.py
@@ -387,7 +387,7 @@ class FileNotebookManager(NotebookManager):
 
         # Move the notebook file
         try:
-            os.rename(old_os_path, new_os_path)
+            shutil.move(old_os_path, new_os_path)
         except Exception as e:
             raise web.HTTPError(500, u'Unknown error renaming notebook: %s %s' % (old_os_path, e))
 
@@ -399,11 +399,11 @@ class FileNotebookManager(NotebookManager):
             new_cp_path = self.get_checkpoint_path(checkpoint_id, new_name, new_path)
             if os.path.isfile(old_cp_path):
                 self.log.debug("Renaming checkpoint %s -> %s", old_cp_path, new_cp_path)
-                os.rename(old_cp_path, new_cp_path)
+                shutil.move(old_cp_path, new_cp_path)
 
         # Move the .py script
         if self.save_script:
-            os.rename(old_py_path, new_py_path)
+            shutil.move(old_py_path, new_py_path)
   
     # Checkpoint-related utilities