From 19c6ee99f96659b38dd9cca842e038dc9a624573 2013-12-13 22:46:51 From: Thomas Kluyver Date: 2013-12-13 22:46:51 Subject: [PATCH] Download as always starts downloads in new window/tab This is a slightly worse user experience if it succeeds, because the new tab flashes up before closing again, but it will let us display an informative error page if it fails, without navigating the user away from the interactive notebook view. --- diff --git a/IPython/html/static/notebook/js/menubar.js b/IPython/html/static/notebook/js/menubar.js index 8036960..a43c76a 100644 --- a/IPython/html/static/notebook/js/menubar.js +++ b/IPython/html/static/notebook/js/menubar.js @@ -83,11 +83,7 @@ var IPython = (function (IPython) { notebook_name + '.ipynb' ) + "?download=" + download.toString(); - if (download) { - window.location.assign(url); - } else { - window.open(url); - } + window.open(url); } MenuBar.prototype.bind_events = function () {