From 29dc2c65eb998838119d89b0611be243aee9dfea 2012-06-12 00:23:21 From: Thomas Kluyver Date: 2012-06-12 00:23:21 Subject: [PATCH] Preserve unavailable_pythons list for post_pr_test script. --- diff --git a/tools/post_pr_test.py b/tools/post_pr_test.py index 7a3a585..01f8d8d 100755 --- a/tools/post_pr_test.py +++ b/tools/post_pr_test.py @@ -3,10 +3,10 @@ """ from test_pr import load_results, post_logs, post_results_comment, print_results -num, results, pr = load_results() +num, results, pr, unavailable_pythons = load_results() results_urls = post_logs(results) -print_results(pr, results_urls) -post_results_comment(pr, results_urls, num) +print_results(pr, results_urls, unavailable_pythons) +post_results_comment(pr, results_urls, num, unavailable_pythons) print() print("Posted test results to pull request") diff --git a/tools/test_pr.py b/tools/test_pr.py index 5ad317b..66b071a 100755 --- a/tools/test_pr.py +++ b/tools/test_pr.py @@ -128,7 +128,7 @@ def run_tests(venv): # Restore $PATH os.environ["PATH"] = orig_path -def markdown_format(pr, results_urls): +def markdown_format(pr, results_urls, unavailable_pythons): def format_result(py, passed, gist_url, missing_libraries): s = "* %s: " % py if passed: @@ -151,11 +151,11 @@ def markdown_format(pr, results_urls): "Not available for testing: " + ", ".join(unavailable_pythons)] return "\n".join(lines) -def post_results_comment(pr, results, num): - body = markdown_format(pr, results) +def post_results_comment(pr, results, num, unavailable_pythons=unavailable_pythons): + body = markdown_format(pr, results, unavailable_pythons) gh_api.post_issue_comment(gh_project, num, body) -def print_results(pr, results_urls): +def print_results(pr, results_urls, unavailable_pythons=unavailable_pythons): print("\n") if pr['mergeable']: print("**Test results for commit %s merged into master**" % pr['head']['sha'][:7]) @@ -174,7 +174,7 @@ def print_results(pr, results_urls): def dump_results(num, results, pr): with open(os.path.join(basedir, 'lastresults.pkl'), 'wb') as f: - pickle.dump((num, results, pr), f) + pickle.dump((num, results, pr, unavailable_pythons), f) def load_results(): with open(os.path.join(basedir, 'lastresults.pkl'), 'rb') as f: