From 4d9f6f00a4f0798e41700c22a839eddff0881692 2014-11-28 01:44:47 From: Peter Odding Date: 2014-11-28 01:44:47 Subject: [PATCH] Always depend on gnureadline if setupext.check_for_readline() fails The inconsistency (asymmetry) of unconditionally adding gnureadline as a dependency of binary distributions can cause issues like reported at https://github.com/paylogic/pip-accel/issues/34 --- diff --git a/setup.py b/setup.py index 8f75c76..d4a98d0 100755 --- a/setup.py +++ b/setup.py @@ -289,7 +289,7 @@ install_requires = [] # add readline if sys.platform == 'darwin': - if any(arg.startswith('bdist') for arg in sys.argv) or not setupext.check_for_readline(): + if not setupext.check_for_readline(): install_requires.append('gnureadline') elif sys.platform.startswith('win'): extras_require['terminal'].append('pyreadline>=2.0')