From 4f7407823efa5407f9293ec1cd1adb8a206211fc 2014-07-29 20:11:34 From: Sylvain Corlay Date: 2014-07-29 20:11:34 Subject: [PATCH] bad call and missing call to unregister_comm --- diff --git a/IPython/html/static/services/kernels/js/comm.js b/IPython/html/static/services/kernels/js/comm.js index 4cb24a6..04307cf 100644 --- a/IPython/html/static/services/kernels/js/comm.js +++ b/IPython/html/static/services/kernels/js/comm.js @@ -56,9 +56,9 @@ define([ return comm.comm_id; }; - CommManager.prototype.unregister_comm = function (comm_id) { + CommManager.prototype.unregister_comm = function (comm) { // Remove a comm from the mapping - delete this.comms[comm_id]; + delete this.comms[comm.comm_id]; }; // comm message handlers @@ -88,7 +88,7 @@ define([ if (comm === undefined) { return; } - delete this.comms[content.comm_id]; + this.unregister_comm(comm); try { comm.handle_close(msg); } catch (e) {