From 580ac96cf4e3239a94f9f044dde9202ebe207cca 2014-03-08 01:48:34 From: Paul Ivanov Date: 2014-03-08 01:48:34 Subject: [PATCH] typo, use keycodes object instead of magic numbers --- diff --git a/IPython/html/static/notebook/js/cell.js b/IPython/html/static/notebook/js/cell.js index dd33ef9..c8253a6 100644 --- a/IPython/html/static/notebook/js/cell.js +++ b/IPython/html/static/notebook/js/cell.js @@ -238,7 +238,7 @@ var IPython = (function (IPython) { * @param {event} event - * @return {Boolean} `true` if CodeMirror should ignore the event, `false` Otherwise */ - CodeCell.prototype.handle_keyevent = function (editor, event) { + Cell.prototype.handle_keyevent = function (editor, event) { // console.log('CM', this.mode, event.which, event.type) diff --git a/IPython/html/static/notebook/js/codecell.js b/IPython/html/static/notebook/js/codecell.js index 1241016..e5753a7 100644 --- a/IPython/html/static/notebook/js/codecell.js +++ b/IPython/html/static/notebook/js/codecell.js @@ -197,7 +197,7 @@ var IPython = (function (IPython) { if (event.keyCode === keycodes.enter && (event.shiftKey || event.ctrlKey || event.altKey)) { // Always ignore shift-enter in CodeMirror as we handle it. return true; - } else if (event.which === 40 && event.type === 'keypress' && IPython.tooltip.time_before_tooltip >= 0) { + } else if (event.which === keycodes.down && event.type === 'keypress' && IPython.tooltip.time_before_tooltip >= 0) { // triger on keypress (!) otherwise inconsistent event.which depending on plateform // browser and keyboard layout ! // Pressing '(' , request tooltip, don't forget to reappend it