From 5827cc8b7a69a67076bbf0c903dfcf0617ca96af 2024-07-03 10:27:17 From: MichaƂ Krassowski <5832902+krassowski@users.noreply.github.com> Date: 2024-07-03 10:27:17 Subject: [PATCH] Add a TODO comment to remember to narrow `global_matches` type --- diff --git a/IPython/core/completer.py b/IPython/core/completer.py index bac9e1d..440953d 100644 --- a/IPython/core/completer.py +++ b/IPython/core/completer.py @@ -2353,6 +2353,7 @@ class IPCompleter(Completer): return _convert_matcher_v1_result_to_v2(matches, type="attribute") else: matches = self.global_matches(context.token) + # TODO: maybe distinguish between functions, modules and just "variables" return _convert_matcher_v1_result_to_v2(matches, type="variable") @completion_matcher(api_version=1)