From 671d3de9d333cbd40a8b342e616366f417fb054b 2014-12-02 22:38:19
From: Jason Grout <jgrout6@bloomberg.net>
Date: 2014-12-02 22:38:19
Subject: [PATCH] Wait for any promises returned by a view's render method before considering the view created

This lets a view wait on children views to be created before considering itself created.

Thanks to @ssunkara for catching this.

---

diff --git a/IPython/html/static/widgets/js/manager.js b/IPython/html/static/widgets/js/manager.js
index e7ee686..c0f17fb 100644
--- a/IPython/html/static/widgets/js/manager.js
+++ b/IPython/html/static/widgets/js/manager.js
@@ -101,8 +101,7 @@ define([
                 var parameters = {model: model, options: options};
                 var view = new ViewType(parameters);
                 view.listenTo(model, 'destroy', view.remove);
-                view.render();
-                return view;
+                return Promise.resolve(view.render()).then(function() {return view;});
             }).catch(utils.reject("Couldn't create a view for model id '" + String(model.id) + "'", true));
         });
         return model.state_change;