From 7bf4a46d554af3c7eb12453728f9f90e54aff1a6 2014-06-09 19:05:40 From: Jonathan Frederic Date: 2014-06-09 19:05:40 Subject: [PATCH] Review comments --- diff --git a/IPython/html/static/base/js/dialog.js b/IPython/html/static/base/js/dialog.js index 9be280a..e81a4be 100644 --- a/IPython/html/static/base/js/dialog.js +++ b/IPython/html/static/base/js/dialog.js @@ -128,7 +128,7 @@ IPython.dialog = (function (IPython) { autoIndent: true, mode: 'application/json', }); - IPython.dialog.modal({ + var modal = IPython.dialog.modal({ title: "Edit " + name + " Metadata", body: dialogform, buttons: { @@ -149,7 +149,8 @@ IPython.dialog = (function (IPython) { Cancel: {} } }); - editor.refresh(); + + modal.on('shown.bs.modal', function(){ editor.refresh(); }); }; return { diff --git a/IPython/html/static/base/less/variables.less b/IPython/html/static/base/less/variables.less index 74fc789..9e0708e 100644 --- a/IPython/html/static/base/less/variables.less +++ b/IPython/html/static/base/less/variables.less @@ -1,15 +1,31 @@ // Our customizations to bootstrap go here. -@black: @gray-darker; +@black: #000; @text-color: @black; @font-size-base: 13px; @font-family-monospace: monospace; // to allow user to customize their fonts @navbar-height: 36px; +@breadcrumb-color: darken(@border_color, 30%); +@blockquote-font-size: inherit; +// Override the modal footer padding that BS3 uses. +.modal-footer { + padding: 7px; +} + +// Disable modal slide-in from top animation. +.modal { + &.fade .modal-dialog { + .translate(0, 0); + } +} + +// Set the default code color. code { color: @black; // default code color in bootstrap is #d14 (crimson / amaranth) } +// Override bootstrap pre element styling. pre { // bootstrap has pre defaults that we don't want to inherit. // start pre tag defaults based on the surrounding context instead. @@ -17,5 +33,10 @@ pre { line-height: inherit; } +// Disable bold labels in BS3 +label { + font-weight: normal; +} + // Our own global variables for all pages go here diff --git a/IPython/html/static/notebook/js/quickhelp.js b/IPython/html/static/notebook/js/quickhelp.js index 76c4ae4..1b80698 100644 --- a/IPython/html/static/notebook/js/quickhelp.js +++ b/IPython/html/static/notebook/js/quickhelp.js @@ -77,7 +77,7 @@ var IPython = (function (IPython) { var element = $('
'); // The documentation - var doc = $('
').addClass('alert'); + var doc = $('
').addClass('alert alert-warning'); doc.append( $('