From 87a7da863a51a9f414af9b2c54876fba64ec9e53 2012-11-16 21:17:09
From: David Warde-Farley <wardefar@iro.umontreal.ca>
Date: 2012-11-16 21:17:09
Subject: [PATCH] Clearer/simpler code suggested by @fperez.

https://github.com/ipython/nbconvert/pull/43#discussion_r2114903

---

diff --git a/converters/base.py b/converters/base.py
index 6b615ac..0d299dd 100755
--- a/converters/base.py
+++ b/converters/base.py
@@ -237,15 +237,13 @@ class Converter(object):
 
         Returns list.
         """
-        # Choose preferred format if available
-        preferred = [xx for xx in self.display_data_priority if xx in output]
-        if preferred:
-            fmt = preferred[0]
+        for fmt in self.display_data_priority:
+            if fmt in output:
+                break
         else:
-            # Choose a format randomly if preference can't be satisfied
-            available = [k for k in output.keys() if k != 'output_type']
-            if available:
-                fmt = available[0]
+            for fmt in output:
+                if fmt != 'output_type':
+                    break
             else:
                 raise RuntimeError('no display data')