From 93a912f6a01a1f708ee6ddd9f8f6c0e19e99eb95 2011-11-28 04:07:01
From: Fernando Perez <Fernando.Perez@berkeley.edu>
Date: 2011-11-28 04:07:01
Subject: [PATCH] Simplify logic (semantics unchanged) in builtins trap.

---

diff --git a/IPython/core/builtin_trap.py b/IPython/core/builtin_trap.py
index 7551334..0cdefd6 100644
--- a/IPython/core/builtin_trap.py
+++ b/IPython/core/builtin_trap.py
@@ -88,17 +88,12 @@ class BuiltinTrap(Configurable):
             self._orig_builtins[key] = orig
             bdict[key] = value
 
-    def remove_builtin(self, key):
+    def remove_builtin(self, key, orig):
         """Remove an added builtin and re-set the original."""
-        try:
-            orig = self._orig_builtins.pop(key)
-        except KeyError:
-            pass
+        if orig is BuiltinUndefined:
+            del __builtin__.__dict__[key]
         else:
-            if orig is BuiltinUndefined:
-                del __builtin__.__dict__[key]
-            else:
-                __builtin__.__dict__[key] = orig
+            __builtin__.__dict__[key] = orig
 
     def activate(self):
         """Store ipython references in the __builtin__ namespace."""
@@ -115,11 +110,9 @@ class BuiltinTrap(Configurable):
     def deactivate(self):
         """Remove any builtins which might have been added by add_builtins, or
         restore overwritten ones to their previous values."""
-        # Note: must iterate over a static keys() list because we'll be
-        # mutating the dict itself
         remove_builtin = self.remove_builtin
-        for key in self._orig_builtins.keys():
-            remove_builtin(key)
+        for key, val in self._orig_builtins.iteritems():
+            remove_builtin(key, val)
         self._orig_builtins.clear()
         self._builtins_added = False
         try: