From 99527ea40fa5b83f13c0cd856333421a3cace3cc 2014-11-03 20:35:10
From: Thomas Kluyver <takowl@gmail.com>
Date: 2014-11-03 20:35:10
Subject: [PATCH] Merge pull request #6844 from minrk/nbformat4-from-backport

a couple of nbformat 4 fixes I noticed while backporting v4 to 2.x
---

diff --git a/IPython/html/static/notebook/js/notebook.js b/IPython/html/static/notebook/js/notebook.js
index bc75dfc..12c0f8b 100644
--- a/IPython/html/static/notebook/js/notebook.js
+++ b/IPython/html/static/notebook/js/notebook.js
@@ -2313,12 +2313,25 @@ define([
         var orig_nbformat = nbmodel.metadata.orig_nbformat;
         var orig_nbformat_minor = nbmodel.metadata.orig_nbformat_minor;
         if (orig_nbformat !== undefined && nbmodel.nbformat !== orig_nbformat) {
-            var msg = "This notebook has been converted from an older " +
-            "notebook format (v"+orig_nbformat+") to the current notebook " +
-            "format (v"+nbmodel.nbformat+"). The next time you save this notebook, the " +
-            "newer notebook format will be used and older versions of IPython " +
-            "may not be able to read it. To keep the older version, close the " +
-            "notebook without saving it.";
+            var src;
+            if (nb.nbformat > nb.orig_nbformat) {
+                src = " an older notebook format ";
+            } else {
+                src = " a newer notebook format ";
+            }
+            
+            var msg = "This notebook has been converted from" + src +
+            "(v"+nb.orig_nbformat+") to the current notebook " +
+            "format (v"+nb.nbformat+"). The next time you save this notebook, the " +
+            "current notebook format will be used.";
+            
+            if (nb.nbformat > nb.orig_nbformat) {
+                msg += " Older versions of IPython may not be able to read the new format.";
+            } else {
+                msg += " Some features of the original notebook may not be available.";
+            }
+            msg += " To preserve the original version, close the " +
+                "notebook without saving it.";
             dialog.modal({
                 notebook: this,
                 keyboard_manager: this.keyboard_manager,
@@ -2330,7 +2343,7 @@ define([
                     }
                 }
             });
-        } else if (orig_nbformat_minor !== undefined && nbmodel.nbformat_minor !== orig_nbformat_minor) {
+        } else if (orig_nbformat_minor !== undefined && nbmodel.nbformat_minor < orig_nbformat_minor) {
             var that = this;
             var orig_vs = 'v' + nbmodel.nbformat + '.' + orig_nbformat_minor;
             var this_vs = 'v' + nbmodel.nbformat + '.' + this.nbformat_minor;
diff --git a/IPython/nbformat/v3/nbformat.v3.schema.json b/IPython/nbformat/v3/nbformat.v3.schema.json
index f51a9b2..8175853 100644
--- a/IPython/nbformat/v3/nbformat.v3.schema.json
+++ b/IPython/nbformat/v3/nbformat.v3.schema.json
@@ -51,6 +51,11 @@
             "type": "integer",
             "minimum": 1
         },
+        "orig_nbformat_minor": {
+            "description": "Original notebook format (minor number) before converting the notebook between versions.",
+            "type": "integer",
+            "minimum": 0
+        },
         "worksheets" : {
             "description": "Array of worksheets",
             "type": "array",
diff --git a/IPython/nbformat/v4/convert.py b/IPython/nbformat/v4/convert.py
index 37e5330..24bf53e 100644
--- a/IPython/nbformat/v4/convert.py
+++ b/IPython/nbformat/v4/convert.py
@@ -241,9 +241,11 @@ def downgrade(nb):
     cells = [ downgrade_cell(cell) for cell in nb.pop('cells') ]
     nb.worksheets = [v3.new_worksheet(cells=cells)]
     nb.metadata.setdefault('name', '')
-    nb.metadata.pop('orig_nbformat', None)
-    nb.metadata.pop('orig_nbformat_minor', None)
-
+    
     # Validate the converted notebook before returning it
     _warn_if_invalid(nb, v3.nbformat)
+    
+    nb.orig_nbformat = nb.metadata.pop('orig_nbformat', nbformat)
+    nb.orig_nbformat_minor = nb.metadata.pop('orig_nbformat_minor', nbformat_minor)
+    
     return nb