From 9b81b02db3660ece985316412131b73c3c8b1375 2009-08-05 00:26:29
From: Brian Granger <ellisonbg@gmail.com>
Date: 2009-08-05 00:26:29
Subject: [PATCH] Added comments to testStrictDict about random test failure on OS X.

On OS X testStrictDict is [OK], but there is a weird error being
printed:  ('EOF in multi-line statement', (36, 0)).  This commit
adds a simple comment about the offending lines.

---

diff --git a/IPython/kernel/tests/engineservicetest.py b/IPython/kernel/tests/engineservicetest.py
index ebb0587..a107f13 100644
--- a/IPython/kernel/tests/engineservicetest.py
+++ b/IPython/kernel/tests/engineservicetest.py
@@ -359,12 +359,15 @@ class IEnginePropertiesTestCase(object):
         return d
     
     def testStrictDict(self):
-        s = """from IPython.kernel.engineservice import get_engine
-p = get_engine(%s).properties"""%self.engine.id
+        s = """from IPython.kernel.engineservice import get_engine; p = get_engine(%s).properties"""%self.engine.id
         d = self.engine.execute(s)
+        # These 3 lines cause a weird testing error on some platforms (OS X).
+        # I am leaving them here in case they are masking some really 
+        # weird reactor issue.  For now I will just keep my eye on this.
         d.addCallback(lambda r: self.engine.execute("p['a'] = lambda _:None"))
         d.addErrback(lambda f: self.assertRaises(error.InvalidProperty,
             f.raiseException))
+        # Below here seems to be fine
         d.addCallback(lambda r: self.engine.execute("p['a'] = range(5)"))
         d.addCallback(lambda r: self.engine.execute("p['a'].append(5)"))
         d.addCallback(lambda r: self.engine.get_properties('a'))