From a7b48096fb72d83d64a6c0cc556ce39d1897c2c1 2011-11-09 03:47:18 From: MinRK Date: 2011-11-09 03:47:18 Subject: [PATCH] use system_raw in terminal, even on Windows `system_raw` uses `os.system` instead of `utils.process.system`, and makes more sense in a Terminal session. There was discussion that it should be otherwise on Windows, but I can't find any actual evidence for why this would be the case, and there are very clear disadvantages to not using `os.system` (see #978 and #181). closes gh-978 --- diff --git a/IPython/frontend/terminal/interactiveshell.py b/IPython/frontend/terminal/interactiveshell.py index a57ecca..fbfe89c 100644 --- a/IPython/frontend/terminal/interactiveshell.py +++ b/IPython/frontend/terminal/interactiveshell.py @@ -112,11 +112,9 @@ class TerminalInteractiveShell(InteractiveShell): config=config, profile_dir=profile_dir, user_ns=user_ns, user_global_ns=user_global_ns, custom_exceptions=custom_exceptions ) - # use os.system instead of utils.process.system by default, except on Windows - if os.name == 'nt': - self.system = self.system_piped - else: - self.system = self.system_raw + # use os.system instead of utils.process.system by default, + # because piped system doesn't make sense in the Terminal: + self.system = self.system_raw self.init_term_title() self.init_usage(usage)