From b156d6954058af82c7b1adff273e6fd48b4dab26 2020-02-21 21:27:31 From: Itamar Turner-Trauring Date: 2020-02-21 21:27:31 Subject: [PATCH] Make sure it exited quickly. --- diff --git a/IPython/utils/tests/test_process.py b/IPython/utils/tests/test_process.py index 023e2e7..e1ae51c 100644 --- a/IPython/utils/tests/test_process.py +++ b/IPython/utils/tests/test_process.py @@ -116,7 +116,6 @@ class SubProcessTestCase(tt.TempFileMixin): subprocess is interrupted. """ if threading.main_thread() != threading.current_thread(): - raise RuntimeEror("Not in main thread") raise nt.SkipTest("Can't run this test if not in main thread.") def interrupt(): @@ -125,14 +124,19 @@ class SubProcessTestCase(tt.TempFileMixin): interrupt_main() threading.Thread(target=interrupt).start() + start = time.time() try: status = system('%s -c "import time; time.sleep(5)"' % python) except KeyboardInterrupt: # Success! return + end = time.time() self.assertNotEqual( status, 0, "The process wasn't interrupted. Status: %s" % (status,) ) + self.assertTrue( + end - start < 2, "Process didn't die quickly: %s" % (end - start) + ) def test_getoutput(self): out = getoutput('%s "%s"' % (python, self.fname))