From b66c93b8639a2f2b64fc0d90f16fdbdf6a0fce6e 2024-02-17 16:46:30
From: krassowski <5832902+krassowski@users.noreply.github.com>
Date: 2024-02-17 16:46:30
Subject: [PATCH] Remove no longer needed note about mypy and mention darker/black

versions used on CI

---

diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
index 6629b62..ae1a8d7 100644
--- a/.github/workflows/python-package.yml
+++ b/.github/workflows/python-package.yml
@@ -28,6 +28,7 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
+        # when changing the versions please update CONTRIBUTING.md too
         pip install --only-binary ':all:' darker==1.5.1 black==22.10.0
     - name: Lint with darker
       run: |
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 164757f..f51a821 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -92,8 +92,7 @@ pytest IPython/core/tests/test_alias.py::test_alias_lifecycle
 
 ## Code style
 
-* Before committing, run `darker -r 60625f241f298b5039cb2debc365db38aa7bb522 <file path>` to apply selective `black` formatting on modified regions using [darker](https://github.com/akaihola/darker).
-* For newly added modules or refactors, please enable static typing analysis with `mypy` for the modified module by adding the file path in [`mypy.yml`](https://github.com/ipython/ipython/blob/main/.github/workflows/mypy.yml) workflow.
+* Before committing, run `darker -r 60625f241f298b5039cb2debc365db38aa7bb522 <file path>` to apply selective `black` formatting on modified regions using [darker](https://github.com/akaihola/darker)==1.5.1 and black==22.10.0
 * As described in the pull requests section, please avoid excessive formatting changes; if a formatting-only commit is necessary, consider adding its hash to [`.git-blame-ignore-revs`](https://github.com/ipython/ipython/blob/main/.git-blame-ignore-revs) file.
 
 ## Documentation