From bfb620f952e72f4002218b3e93b7c90e33fcc019 2016-01-28 18:00:26 From: Min RK Date: 2016-01-28 18:00:26 Subject: [PATCH] Merge pull request #9191 from Carreau/insecure Update release script not to upload insecurly --- diff --git a/tools/release b/tools/release index 9202874..5ba7c19 100755 --- a/tools/release +++ b/tools/release @@ -54,18 +54,18 @@ if 'upload' not in sys.argv: print("`./release upload` to register and release") sys.exit(0) -# Register with the Python Package Index (PyPI) -print( 'Registering with PyPI...') +# Not Registering with PyPI, registering with setup.py is insecure as communication is not encrypted cd(ipdir) -sh('./setup.py register') # Upload all files -sh(sdists + ' upload') +sh(sdists) for py in ('2.7', '3.4'): - sh('python%s setupegg.py bdist_wheel upload' % py) + sh('python%s setupegg.py bdist_wheel' % py) + +print('Will not upload with setuptools as upload connection is insecure. Please use `twine upload dist/*` to upload the files to PyPI') cd(distdir) -print( 'Uploading distribution files...') +print( 'Uploading distribution files to GitHub...') for fname in os.listdir('.'): # TODO: update to GitHub releases API @@ -75,6 +75,7 @@ for fname in os.listdir('.'): post_download("ipython/ipython", fname, description=desc) # Make target dir if it doesn't exist +print('Uploading IPython to backup site.') sh('ssh %s "mkdir -p %s/release/%s" ' % (archive_user, archive_dir, version)) sh('scp * %s' % release_site) diff --git a/tools/toollib.py b/tools/toollib.py index 48028e9..020560b 100644 --- a/tools/toollib.py +++ b/tools/toollib.py @@ -4,7 +4,6 @@ from __future__ import print_function # Library imports import os -import sys # Useful shorthands pjoin = os.path.join