From c7e6d9ea7c36493577de567fbdb795939cd18f9a 2010-09-03 22:20:45
From: Brian Granger <ellisonbg@gmail.com>
Date: 2010-09-03 22:20:45
Subject: [PATCH] Merge branch 'newkernel' of github.com:ipython/ipython into upstream-newkernel

---

diff --git a/IPython/zmq/entry_point.py b/IPython/zmq/entry_point.py
index 459d1fb..5455f9a 100644
--- a/IPython/zmq/entry_point.py
+++ b/IPython/zmq/entry_point.py
@@ -5,7 +5,7 @@ launchers.
 # Standard library imports.
 import os
 import socket
-from subprocess import Popen
+from subprocess import Popen, PIPE
 import sys
 
 # System library imports.
@@ -191,20 +191,26 @@ def base_launch_kernel(code, xrep_port=0, pub_port=0, req_port=0, hb_port=0,
     arguments.extend(extra_arguments)
 
     # Spawn a kernel.
-    if independent:
-        if sys.platform == 'win32':
-            proc = Popen(['start', '/b'] + arguments, shell=True)
+    if sys.platform == 'win32':
+        # If using pythonw, stdin, stdout, and stderr are invalid. Popen will
+        # fail unless they are suitably redirected. We don't read from the
+        # pipes, but they must exist.
+        redirect = PIPE if sys.executable.endswith('pythonw.exe') else None
+        if independent:
+            proc = Popen(['start', '/b'] + arguments, shell=True,
+                         stdout=redirect, stderr=redirect, stdin=redirect)
         else:
-            proc = Popen(arguments, preexec_fn=lambda: os.setsid())
-    else:
-        if sys.platform == 'win32':
             from _subprocess import DuplicateHandle, GetCurrentProcess, \
                 DUPLICATE_SAME_ACCESS
             pid = GetCurrentProcess()
             handle = DuplicateHandle(pid, pid, pid, 0, 
                                      True, # Inheritable by new processes.
                                      DUPLICATE_SAME_ACCESS)
-            proc = Popen(arguments + ['--parent', str(int(handle))])
+            proc = Popen(arguments + ['--parent', str(int(handle))],
+                         stdout=redirect, stderr=redirect, stdin=redirect)
+    else:
+        if independent:
+            proc = Popen(arguments, preexec_fn=lambda: os.setsid())
         else:
             proc = Popen(arguments + ['--parent'])