From d1591ab0d0a0de1ec026febffbc72acba193122b 2014-10-08 18:30:29
From: Jessica B. Hamrick <jhamrick@berkeley.edu>
Date: 2014-10-08 18:30:29
Subject: [PATCH] Fix kernel and session tests

---

diff --git a/IPython/html/tests/services/kernel.js b/IPython/html/tests/services/kernel.js
index 4ff1eee..b3caf7e 100644
--- a/IPython/html/tests/services/kernel.js
+++ b/IPython/html/tests/services/kernel.js
@@ -3,11 +3,15 @@
 // Kernel tests
 //
 casper.notebook_test(function () {
+    this.then(function () {
+        this.test.assert(this.kernel_running(), 'kernel: kernel is running');
+    });
+
     this.evaluate(function () {
         IPython.notebook.kernel.kernel_info(
             function(msg){
                 IPython._kernel_info_response = msg;
-            })
+            });
     });
 
     this.waitFor(
@@ -26,39 +30,16 @@ casper.notebook_test(function () {
     });
     
     this.thenEvaluate(function () {
-        var kernel = IPython.notebook.session.kernel;
-        IPython._channels = [
-            kernel.shell_channel,
-            kernel.iopub_channel,
-            kernel.stdin_channel
-        ];
-        kernel.kill();
+        IPython.notebook.kernel.kill();
     });
     
     this.waitFor(function () {
-        return this.evaluate(function(){
-            for (var i=0; i < IPython._channels.length; i++) {
-                var ws = IPython._channels[i];
-                if (ws.readyState !== ws.CLOSED) {
-                    return false;
-                }
-            }
-            return true;
+        return this.evaluate(function () {
+            return IPython.notebook.kernel.is_fully_disconnected();
         });
     });
     
     this.then(function () {
-        var states = this.evaluate(function() {
-            var states = [];
-            for (var i = 0; i < IPython._channels.length; i++) {
-                states.push(IPython._channels[i].readyState);
-            }
-            return states;
-        });
-        
-        for (var i = 0; i < states.length; i++) {
-            this.test.assertEquals(states[i], WebSocket.CLOSED,
-                "Kernel.kill closes websockets[" + i + "]");
-        }
+        this.test.assert(!this.kernel_running(), 'kernel is not running');
     });
 });
diff --git a/IPython/html/tests/services/session.js b/IPython/html/tests/services/session.js
index af066cf..fa6c057 100644
--- a/IPython/html/tests/services/session.js
+++ b/IPython/html/tests/services/session.js
@@ -4,40 +4,21 @@
 //
 
 casper.notebook_test(function () {
-    this.evaluate(function () {
-        var kernel = IPython.notebook.session.kernel;
-        IPython._channels = [
-            kernel.shell_channel,
-            kernel.iopub_channel,
-            kernel.stdin_channel
-        ];
+    this.then(function () {
+        this.test.assert(this.kernel_running(), 'session: kernel is running');
+    });
+
+    this.thenEvaluate(function () {
         IPython.notebook.session.delete();
     });
-    
+
     this.waitFor(function () {
-        return this.evaluate(function(){
-            for (var i=0; i < IPython._channels.length; i++) {
-                var ws = IPython._channels[i];
-                if (ws.readyState !== ws.CLOSED) {
-                    return false;
-                }
-            }
-            return true;
+        return this.evaluate(function () {
+            return IPython.notebook.kernel.is_fully_disconnected();
         });
     });
 
     this.then(function () {
-        var states = this.evaluate(function() {
-            var states = [];
-            for (var i = 0; i < IPython._channels.length; i++) {
-                states.push(IPython._channels[i].readyState);
-            }
-            return states;
-        });
-        
-        for (var i = 0; i < states.length; i++) {
-            this.test.assertEquals(states[i], WebSocket.CLOSED,
-                "Session.delete closes websockets[" + i + "]");
-        }
+        this.test.assert(!this.kernel_running(), 'session deletes kernel');
     });
 });