From e0a5359fc4ada8b2174d9c68b2e81244fcc28636 2014-11-13 22:14:26
From: Min RK <benjaminrk@gmail.com>
Date: 2014-11-13 22:14:26
Subject: [PATCH] use shlex.split on editor hooks on Windows

pipes.quote uses single-quotes, which is wrong on Windows.
But the grouping is still correct after shlex.split.

An alternative would be to use a cmd list, and not do any quoting.
---

diff --git a/IPython/lib/editorhooks.py b/IPython/lib/editorhooks.py
index 2237074..173ba92 100644
--- a/IPython/lib/editorhooks.py
+++ b/IPython/lib/editorhooks.py
@@ -8,6 +8,7 @@ from __future__ import print_function
 
 import os
 import pipes
+import shlex
 import subprocess
 
 from IPython import get_ipython
@@ -15,7 +16,7 @@ from IPython.core.error import TryNext
 from IPython.utils import py3compat
 
 
-def install_editor(template, wait=False):
+def install_editor(template_list, wait=False):
     """Installs the editor that is called by IPython for the %edit magic.
 
     This overrides the default editor, which is generally set by your EDITOR
@@ -48,6 +49,9 @@ def install_editor(template, wait=False):
             line = 0
         cmd = template.format(filename=pipes.quote(filename), line=line)
         print(">", cmd)
+        # pipes.quote doesn't work right on Windows, but it does after splitting
+        if sys.platform.startswith('win'):
+            cmd = shlex.split(cmd)
         proc = subprocess.Popen(cmd, shell=True)
         if wait and proc.wait() != 0:
             raise TryNext()