From e2f1d954763970eb1bd8810eb728c83b72d52065 2013-01-14 07:40:55 From: Matthias BUSSONNIER Date: 2013-01-14 07:40:55 Subject: [PATCH] convention, jQuery variable start with $ all this.xxxx = $(...) change to this.$xxxx I'm thinking of potentially doing it also in parameters that are expected to be jQuery enabled. --- diff --git a/IPython/frontend/html/notebook/static/js/codecell.js b/IPython/frontend/html/notebook/static/js/codecell.js index 0f80c0f..450da1c 100644 --- a/IPython/frontend/html/notebook/static/js/codecell.js +++ b/IPython/frontend/html/notebook/static/js/codecell.js @@ -61,7 +61,7 @@ var IPython = (function (IPython) { this.metaui = new IPython.MetaUI(this); var cell = $('
').addClass('cell border-box-sizing code_cell vbox'); - cell.append(this.metaui.element); + cell.append(this.metaui.$element); cell.attr('tabindex','2'); var input = $('
').addClass('input hbox'); input.append($('
').addClass('prompt input_prompt')); diff --git a/IPython/frontend/html/notebook/static/js/maintoolbar.js b/IPython/frontend/html/notebook/static/js/maintoolbar.js index 96ba391..a73e12d 100644 --- a/IPython/frontend/html/notebook/static/js/maintoolbar.js +++ b/IPython/frontend/html/notebook/static/js/maintoolbar.js @@ -19,7 +19,7 @@ var IPython = (function (IPython) { this.bind_events(); $(this.selector) .append($('