From ef719b62b5c7a32950d05a64e8c988f609174c1b 2012-06-08 18:26:46
From: Takafumi Arakaki <aka.tkf@gmail.com>
Date: 2012-06-08 18:26:46
Subject: [PATCH] Fix a bug in renaming notebook

There was a bug in NotebookManager.save_notebook_object.
Here is how to reproduce:

0. Make sure you don't have Untitled0.
1. Open new notebook Untitled0.
2. Rename it to something else.
3. Copy Untitled0.ipynb to the notebook dir from somewhere.
   (Do not use notebook UI.)
4. New copied Untitled0 cannot be opened.
   The renamed notebook is opened when tried.
   Indeed, accessing to http://localhost:XXXX/notebooks shows
   duplicated notebook_id.

The problem was that NotebookManager.rev_mapping keeps old notebook
name after renaming.

---

diff --git a/IPython/frontend/html/notebook/notebookmanager.py b/IPython/frontend/html/notebook/notebookmanager.py
index 6dea1b2..bc8ec4a 100644
--- a/IPython/frontend/html/notebook/notebookmanager.py
+++ b/IPython/frontend/html/notebook/notebookmanager.py
@@ -228,6 +228,7 @@ class NotebookManager(LoggingConfigurable):
                     os.unlink(old_pypath)
             self.mapping[notebook_id] = new_name
             self.rev_mapping[new_name] = notebook_id
+            del self.rev_mapping[old_name]
 
     def delete_notebook(self, notebook_id):
         """Delete notebook by notebook_id."""