Show More
@@ -257,9 +257,7 b' function(WidgetManager, Underscore, Backbone){' | |||||
257 | // TODO: this is hacky, and makes the view depend on this cell attribute and widget manager behavior |
|
257 | // TODO: this is hacky, and makes the view depend on this cell attribute and widget manager behavior | |
258 | // it would be great to have the widget manager add the cell metadata |
|
258 | // it would be great to have the widget manager add the cell metadata | |
259 | // to the subview without having to add it here. |
|
259 | // to the subview without having to add it here. | |
260 | options = options || {}; |
|
260 | var child_view = this.model.widget_manager.create_view(child_model, options || {}); | |
261 | options.cell = this.options.cell; |
|
|||
262 | var child_view = this.model.widget_manager.create_view(child_model, options); |
|
|||
263 | this.child_views[child_model.id] = child_view; |
|
261 | this.child_views[child_model.id] = child_view; | |
264 | return child_view; |
|
262 | return child_view; | |
265 | }, |
|
263 | }, | |
@@ -267,8 +265,10 b' function(WidgetManager, Underscore, Backbone){' | |||||
267 | delete_child_view: function(child_model, options) { |
|
265 | delete_child_view: function(child_model, options) { | |
268 | // Delete a child view that was previously created using create_child_view. |
|
266 | // Delete a child view that was previously created using create_child_view. | |
269 | var view = this.child_views[child_model.id]; |
|
267 | var view = this.child_views[child_model.id]; | |
|
268 | if (view !== undefined) { | |||
270 | delete this.child_views[child_model.id]; |
|
269 | delete this.child_views[child_model.id]; | |
271 | view.remove(); |
|
270 | view.remove(); | |
|
271 | } | |||
272 | }, |
|
272 | }, | |
273 |
|
273 | |||
274 | do_diff: function(old_list, new_list, removed_callback, added_callback) { |
|
274 | do_diff: function(old_list, new_list, removed_callback, added_callback) { |
General Comments 0
You need to be logged in to leave comments.
Login now