fixed None for type/sender

IPython/kernel/core/notification.py

@@ -20,6 +20,12 b' class NotificationCenter(object):'
     """Synchronous notification center"""
     def __init__(self):
         super(NotificationCenter, self).__init__()
+        self._init_observers()
+    
+    
+    def _init_observers(self):
+        """Initialize observer storage"""
+        
         self.registeredTypes = set() #set of types that are observed
         self.registeredSenders = set() #set of senders that are observed
         self.observers = {} #map (type,sender) => callback (callable)
@@ -41,20 +47,34 b' class NotificationCenter(object):'
                 type and sender.")
         
         # If there are no registered observers for the type/sender pair
-        if((theType not in self.registeredTypes) or
-            (sender not in self.registeredSenders)):
+        if((theType not in self.registeredTypes and None not in self.registeredTypes) or
+            (sender not in self.registeredSenders and None not in self.registeredSenders)):
+            print theType,sender,self.registeredTypes,self.registeredSenders
             return
         
-        keys = ((theType,sender), (None, sender), (theType, None), (None,None))
-        observers = set()
+        for o in self._observers_for_notification(theType, sender):
+            o(theType, sender, args=kwargs)
+    
+        
+    def _observers_for_notification(self, theType, sender):
+        """Find all registered observers that should recieve notification"""
+        
+        keys = (
+                    (theType,sender),
+                    (theType, None),
+                    (None, sender),  
+                    (None,None)
+                )
+        
+        
+        obs = set()
         for k in keys:
-            observers.update(self.observers.get(k, set()))
+            obs.update(self.observers.get(k, set()))
         
-        for o in observers:
-            o(theType, sender, args=kwargs)
+        return obs
         
     
-    def add_observer(self, observerCallback, theType, sender):
+    def add_observer(self, callback, theType, sender):
         """Add an observer callback to this notification center.
         
         The given callback will be called upon posting of notifications of
@@ -75,10 +95,15 b' class NotificationCenter(object):'
             The notification sender. If None, all notifications of theType
             will be posted.
         """
-        assert(observerCallback != None)
+        assert(callback != None)
         self.registeredTypes.add(theType)
         self.registeredSenders.add(sender)
-        self.observers.setdefault((theType,sender), set()).add(observerCallback)
+        self.observers.setdefault((theType,sender), set()).add(callback)
+    
+    def remove_all_observers(self):
+        """Removes all observers from this notification center"""
+        
+        self._init_observers()
     
 
 

IPython/kernel/core/tests/test_notification.py

@@ -15,8 +15,9 b' __docformat__ = "restructuredtext en"'
 # Imports                                                                     
 #-----------------------------------------------------------------------------
 
-from IPython.kernel.core.notification import NotificationCenter,\
-                                            sharedCenter
+import unittest
+import IPython.kernel.core.notification as notification
+from nose.tools import timed
 
 #
 # Supporting test classes
@@ -24,13 +25,14 b' from IPython.kernel.core.notification import NotificationCenter,\\'
 
 class Observer(object):
     """docstring for Observer"""
-    def __init__(self, expectedType, expectedSender, **kwargs):
+    def __init__(self, expectedType, expectedSender, 
+                    center=notification.sharedCenter, **kwargs):
         super(Observer, self).__init__()
         self.expectedType = expectedType
         self.expectedSender = expectedSender
         self.expectedKwArgs = kwargs
         self.recieved = False
-        sharedCenter.add_observer(self.callback, 
+        center.add_observer(self.callback, 
                                     self.expectedType, 
                                     self.expectedSender)
     
@@ -38,8 +40,10 b' class Observer(object):'
     def callback(self, theType, sender, args={}):
         """callback"""
         
-        assert(theType == self.expectedType)
-        assert(sender == self.expectedSender)
+        assert(theType == self.expectedType or
+                self.expectedType == None)
+        assert(sender == self.expectedSender or
+                self.expectedSender == None)
         assert(args == self.expectedKwArgs)
         self.recieved = True
     
@@ -49,6 +53,11 b' class Observer(object):'
         
         assert(self.recieved)
     
+    def reset(self):
+        """reset"""
+        
+        self.recieved = False
+    
 
 
 class Notifier(object):
@@ -58,7 +67,7 b' class Notifier(object):'
         self.theType = theType
         self.kwargs = kwargs
     
-    def post(self, center=sharedCenter):
+    def post(self, center=notification.sharedCenter):
         """fire"""
         
         center.post_notification(self.theType, self,
@@ -69,8 +78,13 b' class Notifier(object):'
 # Test Cases
 #
 
+class NotificationTests(unittest.TestCase):
+    """docstring for NotificationTests"""
+    
+    def tearDown(self):
+        notification.sharedCenter.remove_all_observers()
 
-def test_notification_delivered():
+    def test_notification_delivered(self):
     """Test that notifications are delivered"""
     expectedType = 'EXPECTED_TYPE'
     sender = Notifier(expectedType)
@@ -81,7 +95,7 b' def test_notification_delivered():'
     observer.verify()
 
 
-def test_type_specificity():
+    def test_type_specificity(self):
     """Test that observers are registered by type"""
     
     expectedType = 1
@@ -96,7 +110,7 b' def test_type_specificity():'
     observer.verify()
 
 
-def test_sender_specificity():
+    def test_sender_specificity(self):
     """Test that observers are registered by sender"""
     
     expectedType = "EXPECTED_TYPE"
@@ -110,9 +124,56 b' def test_sender_specificity():'
     observer.verify()
 
 
-def test_complexity_with_no_observers():
+    def test_remove_all_observers(self):
+        """White-box test for remove_all_observers"""
+        
+        for i in xrange(10):
+            Observer('TYPE', None, center=notification.sharedCenter)
+        
+        self.assert_(len(notification.sharedCenter.observers[('TYPE',None)]) >= 10, 
+            "observers registered")
+        
+        notification.sharedCenter.remove_all_observers()
+        
+        self.assert_(len(notification.sharedCenter.observers) == 0, "observers removed")
+    
+    
+    def test_any_sender(self):
+        """test_any_sender"""
+        
+        expectedType = "EXPECTED_TYPE"
+        sender1 = Notifier(expectedType)
+        sender2 = Notifier(expectedType)
+        observer = Observer(expectedType, None)
+        
+        
+        sender1.post()
+        observer.verify()
+        
+        observer.reset()
+        sender2.post()
+        observer.verify()
+        
+    
+    @timed(.01)
+    def test_post_performance(self):
+        """Test that post_notification, even with many registered irrelevant
+        observers is fast"""
+        
+        for i in xrange(10):
+            Observer("UNRELATED_TYPE", None)
+        
+        o = Observer('EXPECTED_TYPE', None)
+        
+        notification.sharedCenter.post_notification('EXPECTED_TYPE', self)
+        
+        o.verify()
+    
+    
+    def test_complexity_with_no_observers(self):
     """Test that the notification center's algorithmic complexity is O(1)
     with no registered observers (for the given notification type)
     """
     
-    assert(False) #I'm not sure how to test this yet
+        self.fail("I'm not sure how to test this.")
+