Incorporating review comments

docs/source/whatsnew/pr/incompat-funcs-removed.rst

@@ -0,0 +1,9 b''
+Functions Removed in 6.x Development cycle
+------------------------------------------
+
+The following functions have been removed in the 
+development cycle marked for the development cycle
+marked for Milestone 6.0.
+
+* is_cmd_found
+* pycmd2argv

IPython/utils/process.py

@@ -1,74 +1,70 b''
 # encoding: utf-8
 """
 Utilities for working with external processes.
 """
 
 # Copyright (c) IPython Development Team.
 # Distributed under the terms of the Modified BSD License.
 
 from __future__ import print_function
 
 import os
 import sys
 
 if sys.platform == 'win32':
     from ._process_win32 import system, getoutput, arg_split, check_pid
 elif sys.platform == 'cli':
     from ._process_cli import system, getoutput, arg_split, check_pid
 else:
     from ._process_posix import system, getoutput, arg_split, check_pid
 
 from ._process_common import getoutputerror, get_output_error_code, process_handler
 from . import py3compat
 
 
 class FindCmdError(Exception):
     pass
 
 
 def find_cmd(cmd):
     """Find absolute path to executable cmd in a cross platform manner.
 
     This function tries to determine the full path to a command line program
     using `which` on Unix/Linux/OS X and `win32api` on Windows.  Most of the
     time it will use the version that is first on the users `PATH`.
 
     Warning, don't use this to find IPython command line programs as there
     is a risk you will find the wrong one.  Instead find those using the
     following code and looking for the application itself::
 
-        from IPython.utils.path import get_ipython_module_path
-        from IPython.utils.process import pycmd2argv
-        argv = pycmd2argv(get_ipython_module_path('IPython.terminal.ipapp'))
-
-    Note, The code for pycmd2argv has been removed now as it was not used
-    anywhere. get_ipython_module_path should give us that same result.
+        import sys
+        argv = [sys.executable, '-m', 'IPython.terminal']
 
     Parameters
     ----------
     cmd : str
         The command line program to look for.
     """
     path = py3compat.which(cmd)
     if path is None:
         raise FindCmdError('command could not be found: %s' % cmd)
     return path
 
 
 def abbrev_cwd():
     """ Return abbreviated version of cwd, e.g. d:mydir """
     cwd = py3compat.getcwd().replace('\\','/')
     drivepart = ''
     tail = cwd
     if sys.platform == 'win32':
         if len(cwd) < 4:
             return cwd
         drivepart,tail = os.path.splitdrive(cwd)
 
 
     parts = tail.split('/')
     if len(parts) > 2:
         tail = '/'.join(parts[-2:])
 
     return (drivepart + (
         cwd == '/' and '/' or tail))