##// END OF EJS Templates
remove incorrect is instance check in children_changed
MinRK -
Show More
@@ -1,60 +1,60 b''
1 1 """ContainerWidget class.
2 2
3 3 Represents a container that can be used to group other widgets.
4 4 """
5 5 #-----------------------------------------------------------------------------
6 6 # Copyright (c) 2013, the IPython Development Team.
7 7 #
8 8 # Distributed under the terms of the Modified BSD License.
9 9 #
10 10 # The full license is in the file COPYING.txt, distributed with this software.
11 11 #-----------------------------------------------------------------------------
12 12
13 13 #-----------------------------------------------------------------------------
14 14 # Imports
15 15 #-----------------------------------------------------------------------------
16 16 from .widget import DOMWidget
17 17 from IPython.utils.traitlets import Unicode, Tuple, Instance, TraitError
18 18
19 19 #-----------------------------------------------------------------------------
20 20 # Classes
21 21 #-----------------------------------------------------------------------------
22 22
23 23 class TupleOfDOMWidgets(Tuple):
24 24 """Like Tuple(Instance(DOMWidget)), but without checking length."""
25 25 def validate_elements(self, obj, value):
26 26 for v in value:
27 27 if not isinstance(v, DOMWidget):
28 28 raise TraitError("Container.children must be DOMWidgets, not %r" % v)
29 29 return value
30 30
31 31 class ContainerWidget(DOMWidget):
32 32 _view_name = Unicode('ContainerView', sync=True)
33 33
34 34 # Keys, all private and managed by helper methods. Flexible box model
35 35 # classes...
36 36 children = TupleOfDOMWidgets()
37 37 _children = TupleOfDOMWidgets(sync=True)
38 38
39 39 def _children_changed(self, name, old, new):
40 40 """Validate children list.
41 41
42 42 Makes sure only one instance of any given model can exist in the
43 43 children list.
44 44 An excellent post on uniqifiers is available at
45 45 http://www.peterbe.com/plog/uniqifiers-benchmark
46 46 which provides the inspiration for using this implementation. Below
47 47 I've implemented the `f5` algorithm using Python comprehensions."""
48 if new is not None and isinstance(new, list):
48 if new is not None:
49 49 seen = {}
50 50 def add_item(i):
51 51 seen[i.model_id] = True
52 52 return i
53 53 self._children = [add_item(i) for i in new if not i.model_id in seen]
54 54
55 55
56 56 class PopupWidget(ContainerWidget):
57 57 _view_name = Unicode('PopupView', sync=True)
58 58
59 59 description = Unicode(sync=True)
60 60 button_text = Unicode(sync=True)
General Comments 0
You need to be logged in to leave comments. Login now