Merge pull request #11790 from Carreau/fix-skip

Fix skip decorator.

IPython/testing/decorators.py

@@ -245,7 +245,9 b' def skip(msg=None):'
          Decorator, which, when applied to a function, causes SkipTest
          to be raised, with the optional message added.
       """
-
+    if msg and not isinstance(msg, str):
+        raise ValueError('invalid object passed to `@skip` decorator, did you '
+                         'meant `@skip()` with brackets ?')
     return skipif(True,msg)
 
 

IPython/testing/tests/test_decorators.py

@@ -46,7 +46,7 b' def trivial():'
     pass
 
 
[e-mail]
[e-mail]()
 def test_deliberately_broken():
     """A deliberately broken test - we want to skip this one."""
     1/0