Add test for installing kernel spec

IPython/kernel/tests/test_kernelspec.py

@@ -1,39 +1,65 b''
 import json
 import os
 from os.path import join as pjoin
 import unittest
 
+from IPython.testing.decorators import onlyif
 from IPython.utils.tempdir import TemporaryDirectory
 from IPython.kernel import kernelspec
 
 sample_kernel_json = {'argv':['cat', '{connection_file}'],
                       'display_name':'Test kernel',
                       'language':'bash',
                      }
 
 class KernelSpecTests(unittest.TestCase):
     def setUp(self):
-        self.tempdir = td = TemporaryDirectory()
+        td = TemporaryDirectory()
+        self.addCleanup(td.cleanup)
         self.sample_kernel_dir = pjoin(td.name, 'kernels', 'Sample')
         os.makedirs(self.sample_kernel_dir)
         json_file = pjoin(self.sample_kernel_dir, 'kernel.json')
         with open(json_file, 'w') as f:
             json.dump(sample_kernel_json, f)
 
         self.ksm = kernelspec.KernelSpecManager(ipython_dir=td.name)
 
-    def tearDown(self):
-        self.tempdir.cleanup()
+        td2 = TemporaryDirectory()
+        self.addCleanup(td2.cleanup)
+        self.installable_kernel = td2.name
+        with open(pjoin(self.installable_kernel, 'kernel.json'), 'w') as f:
+            json.dump(sample_kernel_json, f)
 
     def test_find_kernel_specs(self):
         kernels = self.ksm.find_kernel_specs()
         self.assertEqual(kernels['sample'], self.sample_kernel_dir)
 
     def test_get_kernel_spec(self):
         ks = self.ksm.get_kernel_spec('SAMPLE')  # Case insensitive
         self.assertEqual(ks.resource_dir, self.sample_kernel_dir)
         self.assertEqual(ks.argv, sample_kernel_json['argv'])
         self.assertEqual(ks.display_name, sample_kernel_json['display_name'])
         self.assertEqual(ks.language, sample_kernel_json['language'])
         self.assertEqual(ks.codemirror_mode, sample_kernel_json['language'])
         self.assertEqual(ks.env, {})
+    
+    def test_install_kernel_spec(self):
+        self.ksm.install_kernel_spec(self.installable_kernel,
+                                     kernel_name='tstinstalled')
+        self.assertIn('tstinstalled', self.ksm.find_kernel_specs())
+        
+        with self.assertRaises(OSError):
+            self.ksm.install_kernel_spec(self.installable_kernel,
+                                         kernel_name='tstinstalled')
+        
+        # Smoketest that this succeeds
+        self.ksm.install_kernel_spec(self.installable_kernel,
+                                     kernel_name='tstinstalled',
+                                     replace=True)
+    
+    @onlyif(os.name != 'nt' and os.getuid() != 0, "needs Unix system and non-root uid")
+    def test_cant_install_kernel_spec(self):
+        with self.assertRaises(OSError):
+            self.ksm.install_kernel_spec(self.installable_kernel,
+                                         kernel_name='tstinstalled',
+                                         system=True)