Fixing two minor things for review.

* Using basestring for str, unicode test.
* png->jpeg in display_jpeg.

IPython/core/display.py

@@ -1,373 +1,373 b''
 # -*- coding: utf-8 -*-
 """Top-level display functions for displaying object in different formats.
 
 Authors:
 
 * Brian Granger
 """
 
 #-----------------------------------------------------------------------------
 #       Copyright (C) 2008-2010 The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
 #-----------------------------------------------------------------------------
 
 #-----------------------------------------------------------------------------
 # Imports
 #-----------------------------------------------------------------------------
 
 from .displaypub import (
     publish_pretty, publish_html,
     publish_latex, publish_svg,
     publish_png, publish_json,
     publish_javascript, publish_jpeg
 )
 
 #-----------------------------------------------------------------------------
 # Main functions
 #-----------------------------------------------------------------------------
 
 def display(*objs, **kwargs):
     """Display a Python object in all frontends.
 
     By default all representations will be computed and sent to the frontends.
     Frontends can decide which representation is used and how.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display.
     include : list or tuple, optional
         A list of format type strings (MIME types) to include in the
         format data dict. If this is set *only* the format types included
         in this list will be computed.
     exclude : list or tuple, optional
         A list of format type string (MIME types) to exclue in the format
         data dict. If this is set all format types will be computed,
         except for those included in this argument.
     """
     include = kwargs.get('include')
     exclude = kwargs.get('exclude')
     
     from IPython.core.interactiveshell import InteractiveShell
     inst = InteractiveShell.instance()
     format = inst.display_formatter.format
     publish = inst.display_pub.publish
 
     for obj in objs:
         format_dict = format(obj, include=include, exclude=exclude)
         publish('IPython.core.display.display', format_dict)
 
 
 def display_pretty(*objs, **kwargs):
     """Display the pretty (default) representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw text data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_pretty(obj)
     else:
         display(*objs, include=['text/plain'])
 
 
 def display_html(*objs, **kwargs):
     """Display the HTML representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw HTML data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_html(obj)
     else:
         display(*objs, include=['text/plain','text/html'])
 
 
 def display_svg(*objs, **kwargs):
     """Display the SVG representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw svg data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_svg(obj)
     else:
         display(*objs, include=['text/plain','image/svg+xml'])
 
 
 def display_png(*objs, **kwargs):
     """Display the PNG representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw png data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_png(obj)
     else:
         display(*objs, include=['text/plain','image/png'])
 
 
 def display_jpeg(*objs, **kwargs):
     """Display the JPEG representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw JPEG data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
-            publish_png(obj)
+            publish_jpeg(obj)
     else:
         display(*objs, include=['text/plain','image/jpeg'])
 
 
 def display_latex(*objs, **kwargs):
     """Display the LaTeX representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw latex data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_latex(obj)
     else:
         display(*objs, include=['text/plain','text/latex'])
 
 
 def display_json(*objs, **kwargs):
     """Display the JSON representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw json data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_json(obj)
     else:
         display(*objs, include=['text/plain','application/json'])
 
 
 def display_javascript(*objs, **kwargs):
     """Display the Javascript representation of an object.
 
     Parameters
     ----------
     objs : tuple of objects
         The Python objects to display, or if raw=True raw javascript data to
         display.
     raw : bool
         Are the data objects raw data or Python objects that need to be
         formatted before display? [default: False]
     """
     raw = kwargs.pop('raw',False)
     if raw:
         for obj in objs:
             publish_javascript(obj)
     else:
         display(*objs, include=['text/plain','application/javascript'])
 
 #-----------------------------------------------------------------------------
 # Smart classes
 #-----------------------------------------------------------------------------
 
 
 class DisplayObject(object):
     """An object that wraps data to be displayed."""
 
     _read_flags = 'r'
 
     def __init__(self, data=None, url=None, filename=None):
         """Create a display object given raw data.
 
         When this object is returned by an expression or passed to the
         display function, it will result in the data being displayed
         in the frontend. The MIME type of the data should match the
         subclasses used, so the Png subclass should be used for 'image/png'
         data. If the data is a URL, the data will first be downloaded
         and then displayed. If 
 
         Parameters
         ----------
         data : unicode, str or bytes
             The raw data or a URL to download the data from.
         url : unicode
             A URL to download the data from.
         filename : unicode
             Path to a local file to load the data from.
         """
         if data is not None and data.startswith('http'):
             self.url = data
             self.filename = None
             self.data = None
         else:
             self.data = data
             self.url = url
             self.filename = None if filename is None else unicode(filename)
         self.reload()
 
     def reload(self):
         """Reload the raw data from file or URL."""
         if self.filename is not None:
             with open(self.filename, self._read_flags) as f:
                 self.data = f.read()
         elif self.url is not None:
             try:
                 import urllib2
                 response = urllib2.urlopen(self.url)
                 self.data = response.read()
             except:
                 self.data = None
 
 class Pretty(DisplayObject):
 
     def _repr_pretty_(self):
         return self.data
 
 
 class HTML(DisplayObject):
 
     def _repr_html_(self):
         return self.data
 
 
 class Math(DisplayObject):
 
     def _repr_latex_(self):
         return self.data
 
 
 class SVG(DisplayObject):
 
     def _repr_svg_(self):
         return self.data
 
 
 class JSON(DisplayObject):
 
     def _repr_json_(self):
         return self.data
 
 
 class Javascript(DisplayObject):
 
     def _repr_javascript_(self):
         return self.data
 
 
 class Image(DisplayObject):
 
     _read_flags = 'rb'
 
     def __init__(self, data=None, url=None, filename=None, format=u'png', embed=False):
         """Create a display an PNG/JPEG image given raw data.
 
         When this object is returned by an expression or passed to the
         display function, it will result in the image being displayed
         in the frontend.
 
         Parameters
         ----------
         data : unicode, str or bytes
             The raw data or a URL to download the data from.
         url : unicode
             A URL to download the data from.
         filename : unicode
             Path to a local file to load the data from.
         format : unicode
             The format of the image data (png/jpeg/jpg). If a filename or URL is given
             for format will be inferred from the filename extension.
         embed : bool
             Should the image data be embedded in the notebook using a data URI (True)
             or be loaded using an <img> tag. Set this to True if you want the image
             to be viewable later with no internet connection. If a filename is given
             embed is always set to True.
         """
         if filename is not None:
             ext = self._find_ext(filename)
         elif url is not None:
             ext = self._find_ext(url)
         elif data.startswith('http'):
             ext = self._find_ext(data)
         else:
             ext = None
         if ext is not None:
             if ext == u'jpg' or ext == u'jpeg':
                 format = u'jpeg'
             if ext == u'png':
                 format = u'png'
         self.format = unicode(format).lower()
         self.embed = True if filename is not None else embed
         super(Image, self).__init__(data=data, url=url, filename=filename)
 
     def reload(self):
         """Reload the raw data from file or URL."""
         if self.embed:
             super(Image,self).reload()
 
     def _repr_html_(self):
         if not self.embed:
             return u'<img src="%s" />' % self.url
 
     def _repr_png_(self):
         if self.embed and self.format == u'png':
             return self.data
 
     def _repr_jpeg_(self):
         if self.embed and (self.format == u'jpeg' or self.format == u'jpg'):
             return self.data
 
     def _find_ext(self, s):
         return unicode(s.split('.')[-1].lower())

IPython/core/displaypub.py

@@ -1,298 +1,298 b''
 """An interface for publishing rich data to frontends.
 
 There are two components of the display system:
 
 * Display formatters, which take a Python object and compute the
   representation of the object in various formats (text, HTML, SVg, etc.).
 * The display publisher that is used to send the representation data to the
   various frontends.
 
 This module defines the logic display publishing. The display publisher uses
 the ``display_data`` message type that is defined in the IPython messaging
 spec.
 
 Authors:
 
 * Brian Granger
 """
 
 #-----------------------------------------------------------------------------
 #       Copyright (C) 2008-2010 The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
 #-----------------------------------------------------------------------------
 
 #-----------------------------------------------------------------------------
 # Imports
 #-----------------------------------------------------------------------------
 
 from __future__ import print_function
 
 from IPython.config.configurable import Configurable
 
 #-----------------------------------------------------------------------------
 # Main payload class
 #-----------------------------------------------------------------------------
 
 class DisplayPublisher(Configurable):
     """A traited class that publishes display data to frontends.
 
     Instances of this class are created by the main IPython object and should
     be accessed there.
     """
 
     def _validate_data(self, source, data, metadata=None):
         """Validate the display data.
 
         Parameters
         ----------
         source : str
             The fully dotted name of the callable that created the data, like
             :func:`foo.bar.my_formatter`.
         data : dict
             The formata data dictionary.
         metadata : dict
             Any metadata for the data.
         """
 
-        if not isinstance(source, (str,unicode)):
+        if not isinstance(source, basestring):
             raise TypeError('source must be a str, got: %r' % source)
         if not isinstance(data, dict):
             raise TypeError('data must be a dict, got: %r' % data)
         if metadata is not None:
             if not isinstance(metadata, dict):
                 raise TypeError('metadata must be a dict, got: %r' % data)
 
     def publish(self, source, data, metadata=None):
         """Publish data and metadata to all frontends.
 
         See the ``display_data`` message in the messaging documentation for
         more details about this message type.
 
         The following MIME types are currently implemented:
 
         * text/plain
         * text/html
         * text/latex
         * application/json
         * application/javascript
         * image/png
         * image/jpeg
         * image/svg+xml
 
         Parameters
         ----------
         source : str
             A string that give the function or method that created the data,
             such as 'IPython.core.page'.
         data : dict
             A dictionary having keys that are valid MIME types (like 
             'text/plain' or 'image/svg+xml') and values that are the data for
             that MIME type. The data itself must be a JSON'able data
             structure. Minimally all data should have the 'text/plain' data,
             which can be displayed by all frontends. If more than the plain
             text is given, it is up to the frontend to decide which
             representation to use.
         metadata : dict
             A dictionary for metadata related to the data. This can contain
             arbitrary key, value pairs that frontends can use to interpret
             the data.
         """
         from IPython.utils import io
         # The default is to simply write the plain text data using io.stdout.
         if data.has_key('text/plain'):
             print(data['text/plain'], file=io.stdout)
 
 
 def publish_display_data(source, data, metadata=None):
     """Publish data and metadata to all frontends.
 
     See the ``display_data`` message in the messaging documentation for
     more details about this message type.
 
     The following MIME types are currently implemented:
 
     * text/plain
     * text/html
     * text/latex
     * application/json
     * application/javascript
     * image/png
     * image/jpeg
     * image/svg+xml
 
     Parameters
     ----------
     source : str
         A string that give the function or method that created the data,
         such as 'IPython.core.page'.
     data : dict
         A dictionary having keys that are valid MIME types (like 
         'text/plain' or 'image/svg+xml') and values that are the data for
         that MIME type. The data itself must be a JSON'able data
         structure. Minimally all data should have the 'text/plain' data,
         which can be displayed by all frontends. If more than the plain
         text is given, it is up to the frontend to decide which
         representation to use.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     from IPython.core.interactiveshell import InteractiveShell
     InteractiveShell.instance().display_pub.publish(
         source,
         data,
         metadata
     )
 
 
 def publish_pretty(data, metadata=None):
     """Publish raw text data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw text data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_pretty',
         {'text/plain':data},
         metadata=metadata
     )
 
 
 def publish_html(data, metadata=None):
     """Publish raw HTML data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw HTML data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_html',
         {'text/html':data},
         metadata=metadata
     )
 
 
 def publish_latex(data, metadata=None):
     """Publish raw LaTeX data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw LaTeX data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_latex',
         {'text/latex':data},
         metadata=metadata
     )
 
 def publish_png(data, metadata=None):
     """Publish raw binary PNG data to all frontends.
 
     Parameters
     ----------
     data : str/bytes
         The raw binary PNG data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_png',
         {'image/png':data},
         metadata=metadata
     )
 
 
 def publish_jpeg(data, metadata=None):
     """Publish raw binary JPEG data to all frontends.
 
     Parameters
     ----------
     data : str/bytes
         The raw binary JPEG data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_jpeg',
         {'image/jpeg':data},
         metadata=metadata
     )
 
 
 def publish_svg(data, metadata=None):
     """Publish raw SVG data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw SVG data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_svg',
         {'image/svg+xml':data},
         metadata=metadata
     )
 
 def publish_json(data, metadata=None):
     """Publish raw JSON data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw JSON data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_json',
         {'application/json':data},
         metadata=metadata
     )
 
 def publish_javascript(data, metadata=None):
     """Publish raw Javascript data to all frontends.
 
     Parameters
     ----------
     data : unicode
         The raw Javascript data to publish.
     metadata : dict
         A dictionary for metadata related to the data. This can contain
         arbitrary key, value pairs that frontends can use to interpret
         the data.
     """
     publish_display_data(
         u'IPython.core.displaypub.publish_javascript',
         {'application/javascript':data},
         metadata=metadata
     )